Error::description() deprecated, should use Display trait about robusta HOT 9 OPEN

@EliseChouleur assuming you're asking me, it may take me some time, but I'll give the PR a shot on Android and desktop and reply with the results!

from robusta.

I checked the source code for Error in the standard lib, and yeah, description() is indeed hardcoded to that string.

From error.rs:

from robusta.

It's been buried for a while: rust-lang/rfcs#2230

from robusta.

Thank you for the issue! I'll try to fix it ASAP as it seems it impacts already other users #29

from robusta.

I guess a recent version of Rust just shot that function off of std, since it's been deprecated for long enough :p

But yeah, using Display will make errors actually print something useful to make debugging easier, since description was made useless for quite some time now with the hardcoded message.

P.S.: Thanks a lot for this incredible crate! It makes JNI interop a breeze, alongside cargo-ndk which makes building for Android (with NDK) an easy one-line command!

from robusta.

Hi! Any updates on this?

from robusta.

Hi !
Could you check with darling update ? #31

from robusta.

Hi again! Sorry for my delay, but I can confirm that #31 fixes the issue on Android.

Now instead of the confusing:
java.lang.RuntimeException: JNI call error!. Cause: description() is deprecated; use Display
it correctly reports the error message
java.lang.RuntimeException: JNI call error!. Cause: Java exception was thrown

So updating darling is a valid fix. I don't expect there to be any difference on the desktop (JVM) side, since this bug is purely from the Rust side.

from robusta.

This makes me wonder, however, that it should be possible to pass a custom message to JniError::JavaException type, so that error messages are generally more helpful.

For example in this case, if I want information about the cause of the error, I'd have to log it right before returning the JniError::JavaException to keep those details.

However this should be its own issue.

from robusta.