Code Monkey home page Code Monkey logo

Comments (7)

gildas-lormeau avatar gildas-lormeau commented on June 2, 2024

Thank you for the detailed report, I was able to reproduce and fix the issue. The fix is available in the version 2.7.37 I've just published on NPM and JSR.

from zip.js.

akesling avatar akesling commented on June 2, 2024

Thank you for the quick reply.

Have you updated https://gildas-lormeau.github.io/zip-manager/ to use 2.7.37? Using 2.7.37 in my project does not fix the error and I'm still seeing it on https://gildas-lormeau.github.io/zip-manager/ per the reproduction steps.

from zip.js.

gildas-lormeau avatar gildas-lormeau commented on June 2, 2024

it should indeed be fixed in the demo. Did you refresh the page to make sure the service worker is updated? On my end, I do not see any uncaught exception anymore when trying to reproduce the issue.

from zip.js.

akesling avatar akesling commented on June 2, 2024

Things look good today! You're probably right... something could easily have been cached out of sight somewhere even with no-cache on in the dev tools.

Thank you.

from zip.js.

gildas-lormeau avatar gildas-lormeau commented on June 2, 2024

Actually, the service worker is always updated after a refresh. This is how I decided to implement transparent updates in the demo.

from zip.js.

akesling avatar akesling commented on June 2, 2024

Maybe there was an HTTP proxy cache somewhere still handing me the old zip-manager? 🤷

I'm less sure as to why my local build had the issue yesterday and worked today though.... Hopefully there's nothing flakey lurking in the shadows.

from zip.js.

gildas-lormeau avatar gildas-lormeau commented on June 2, 2024

FYI, I removed the try/catch surrounding the Writer#close() calls in the last version as it didn't work as intended (the exception was not caught). Hopefully, this will make the error more visible if it's still present.

from zip.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.