Comments (3)
jmrog
commented on May 18, 2024
Just to add: if you go to your demo, open a tooltip, and then resize the window, you can see the behavior I'm talking about (no repositioning -- the tooltip just "hangs"). The demo works with the changes from PR #22 incorporated, though.
If the PR is merged, an additional option to consider is allowing the user to adjust the sensitivity of the debouncing. I initially had it at 100ms, but that was still too sensitive -- updates were too frequent -- so I changed it to 200ms, but right now it is hard-coded.
from react-joyride.
gilbarbara
commented on May 18, 2024
hey @jmrog
Yeah, I've added those checks to prevent too many state changes but I forgot to test the resizing afterwards..
I've copied your changes locally and will test some more.
from react-joyride.
gilbarbara
commented on May 18, 2024
@jmrog Pushed 0.7.4 to npm
Thanks
from react-joyride.
Related Issues (20)
- Beacon is showing above the other component as showing in the picture HOT 1
- upgrade to react-floater 0.8.2 HOT 1
- scrolling to step doesn't seem to respect `scroll-margin-top` HOT 1
- Global is not defined HOT 4
- Placement for bottom-start does not re-position when scrolling HOT 4
- Type Step returns any HOT 4
- Loader problem HOT 21
- How to pass helpers in tooltipComponent ? HOT 1
- [Tooltip] Displayed in wrong position in next.js HOT 5
- Add Link to Docs on the Demo site
- Uncaught TypeError: Cannot read properties of null (reading 'nodeName') HOT 1
- type error: '?' expected. HOT 4
- Can't import the named export 'Component' from non EcmaScript module (only default export is available) HOT 14
- isRequiredIf is not a function from "react-floater" HOT 8
- Open the second step when open joyride,i want to not show the first step like "lets begin our journey" in the demo page
- error TS2309: An export assignment cannot be used in a module with other exported elements. HOT 12
- RangeError: Maximum call stack size exceeded after build using the vite bundler HOT 1
- Constants Links on docs not found HOT 1
- Shows a not found error when loading a route directly
- import error in typescript project HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-joyride.