minijson_reader does not distinguish between an unparsable value and a value parsable as zero about minijson_reader HOT 3 CLOSED

I'll be submitting a PR shortly!

from minijson_reader.

Hey @michaelkourlas, I went on a refactoring spree and reworked the value class entirely, on the rework_number_parsing branch.

These *_representation_available() functions are no longer a thing (and I wouldn't know how to neatly bring them back) because those representations are created lazily by calling value.as<T>() with T being an arithmetic type. std::range_error is thrown if the number does not fit in T.

from minijson_reader.

This library really isn't great, and if I were to rewrite it now from scratch it would look very different (but there are probably better alternatives around anyway, even respecting the same constraints e.g. no heap memory allocations).

#4 has been around for years, and I haven't had time to properly think about the problem of making number parsing less rubbish, nor did anyone come up in the meantime with a good solution ready for me to implement (or to just merge).

Given the context, I agree with your idea of adding those two bools to at least solve this particular issue. The fastest way for you to have it done is, well, to issue a pull request. If you keep it single-topic, add the tests and the documentation, and make it easy to review, I'll merge it straightaway.

from minijson_reader.