Comments (3)
I'm maintaining the java version but this might be an issue with all releases.
Just wierd that no one has noticed it before ;). I'll try to find the problem.
Original comment by [email protected]
on 20 Aug 2010 at 7:24
from poly2tri.
Thanks for finding this issue!
There was no problem with the triangulation. But there are some triangles that
should be removed after the triangulation that is added as part of the
algorithm. Is special cases the code doing that could remove the first left or
right valid triangle in a PointSet triangulation. The PolygonSet triangulation
was not affected and since that is what I use mostly myself this problem had
not emerged.
You can add this fix until I get in touch with the C# maintainer for the fix.
In class: DTSweep
In method: private static void FinalizationConvexHull( DTSweepContext tcx )
After the line: TurnAdvancingFrontConvex( tcx, n2, n3 );
Add this:
n1 = tcx.Front.Tail.Prev;
if( n1.Triangle.Contains( n1.Next.Point ) && n1.Triangle.Contains( n1.Prev.Point ) )
{
t1 = n1.Triangle.neighborAcross( n1.Point );
RotateTrianglePair( n1.Triangle, n1.Point, t1, t1.OppositePoint( n1.Triangle, n1.Point ) );
}
n1 = tcx.Front.Head.Next;
if( n1.Triangle.Contains( n1.Prev.Point ) && n1.Triangle.Contains( n1.Next.Point ) )
{
t1 = n1.Triangle.NeighborAcross( n1.Point );
RotateTrianglePair( n1.Triangle, n1.Point, t1, t1.OppositePoint( n1.Triangle, n1.Point ) );
}
Hope I didn't add a typo when converting my Java code to C# :-)
Original comment by [email protected]
on 20 Aug 2010 at 11:30
- Changed state: Fixed
from poly2tri.
I just added Issue #15 for the c++ version, and then noticed this. Perhaps it
is related? I'm also working with simple 4 point sets for now, so could this
issue still exist in the c++ version?
Original comment by [email protected]
on 16 Dec 2010 at 8:52
from poly2tri.
Related Issues (20)
- Java source unbuildable in 1.7+
- Build failed when compliling with -we4715
- Java findbugs - nullcheck of value previously dereferenced HOT 1
- [java] Tessellation with hole error HOT 4
- Polygon with hole HOT 10
- [java] Missing triangle in non-constrained delaunay HOT 3
- Problem building library
- the EPSILON value is not exported in the python/cython version HOT 1
- Odd crash on sanitized input (c++) HOT 8
- CMake build script
- Inconsistent behavior with holes that share a point HOT 17
- add typedef for "double"
- add typedef for std::vector<Point*>, std::vector<Triangle*> and other containers
- Triangulate crashes in sweep.cc:703 HOT 3
- java version compile error HOT 3
- Polygon.getHoles() missing HOT 5
- poly2tri crashes on a very simple geometry HOT 1
- crash with attached polygon HOT 2
- Crash when triangulating a polygon HOT 1
- crash with square polygon HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from poly2tri.