Code Monkey home page Code Monkey logo

Comments (4)

GoogleCodeExporter avatar GoogleCodeExporter commented on July 19, 2024
Thanks for finding the leaks! Care to submit a patch?

Original comment by [email protected] on 13 Mar 2010 at 2:46

from poly2tri.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 19, 2024
The CreateAdvancingFront leak seems to be a matter of dealing with this TODO in
Sweep::Fill() at sweep/sweep.cc line 210:

    -  // TODO: delete node from memory
    -  //tcx.RemoveNode(node);
    +  tcx.RemoveNode(&node);

And then we have to avoid using the freed memory in Sweep::FillAdvancingFront() 
line
230 and similarly at line 240.  Partial workaround:

    -    Fill(tcx, *node);
    -    node = node->next;
    +    Node *tmp = node;
    +    node = node->next;
    +    Fill(tcx, *tmp);

That works with 'dude.dat' but segfaults with some other tests like 'bird.dat'. 
There are other pointers to the node being deleted... I don't have time to sort 
it
all out now.

Original comment by [email protected] on 9 Apr 2010 at 3:27

from poly2tri.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 19, 2024
The problem stems from NOT deleting nodes from memory after they are discarded 
from 
the advancing front. I know how to fix; it's just a matter of finding the time.

Original comment by [email protected] on 9 Apr 2010 at 3:31

  • Changed state: Accepted

from poly2tri.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 19, 2024
Fixed memory leaks by manually deleting nodes in obvious places when they're no 
longer 
needed. There were still a few strays that I did not track down, although I 
solved 
this problem by simply stuffing all new nodes into a vector container. If 
there's ever 
a need for a non-STL version someone will need to spend a little extra time and 
fix. 

Original comment by [email protected] on 23 Apr 2010 at 5:24

  • Changed state: Fixed

from poly2tri.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.