[Feature Request]: pure client mode about gosip HOT 10 CLOSED

Hello @YiuTerran ,
probably I can append tp protocol auto-intialization also in the Send message... And I hope it will not break anything.
This change should allow sending SIP requests without listeners setup, but sure will correctly work only with reliable transports

from gosip.

I just use a mock Listener for my purpose:

type Listener struct {
	network string
	addr    net.Addr
	ch      chan net.Conn
}

func ListenTCP(network string, addr *net.TCPAddr) (net.Listener, error) {
	return &Listener{
		network: network,
		addr:    addr,
		ch:      make(chan net.Conn, 1),
	}, nil
}

// Accept never return
func (l Listener) Accept() (net.Conn, error) {
	return <-l.ch, io.EOF
}

func (l Listener) Close() error {
	defer func() {
		if i := recover(); i != nil {
			//just ignore
		}
	}()
        close(l.ch)
	return nil
}

func (l Listener) Addr() net.Addr {
	return l.addr
}

from gosip.

@YiuTerran I have pushed a patch to the dev branch. Can you try it in your app/env?
You can install it with go get github.com/ghettovoice/gosip@dev

from gosip.

@YiuTerran I have pushed a patch to the dev branch. Can you try it in your app/env? You can install it with go get github.com/ghettovoice/gosip@dev

ok, i will try it next week. thanks very much~

from gosip.

Sorry for late reply. I just test the dev branch, it looks that everything is fine without listening any port when using TCP.

Thanks for your help~

from gosip.

@ghettovoice But i just review the code, found a little problem:

func (tpl *layer) getProtocol(network string) (p Protocol, err error) {
	var ok bool
       // not goroutine safe, we need some func like `LoadOrStore` here
	p, ok = tpl.protocols.get(protocolKey(network))
	if ok {
		return
	}
	p, err = protocolFactory(
		network,
		tpl.pmsgs,
		tpl.perrs,
		tpl.canceled,
		tpl.msgMapper,
		tpl.Log(),
	)
	if err != nil {
		return nil, err
	}
	tpl.protocols.put(protocolKey(p.Network()), p)
	return p, nil
}

from gosip.

tpl.protocols points to internal map+mutex store

from gosip.

tpl.protocols points to internal map+mutex store

Yeah, but data race happens between get and put. It's not a big problem.

from gosip.

Ah, I see now. Do you talking about that get and put should be made as single "atomic" action?

from gosip.

Ah, I see now. Do you talking about that get and put should be made as single "atomic" action?

Yeah, maybe it's better😃

from gosip.