Code Monkey home page Code Monkey logo

Comments (9)

mainrs avatar mainrs commented on May 30, 2024 1

Hey! Thanks for taking the time to reply!

I totally understand your points and concerns. I can create a PR and we can definitely work together for a v0.2 :)

"do I really want to maintain this crate long term? Really?"

I use aseprite heavily and wanted to create some automated tools that work on the save files. Given my extensive usage I doubt that I will not maintain it on the long-term. And after the specification has implemented, big refactors/implementations will probably happen only if a new format is published. And the occasional bug fixes of course ;)

I would rather not transfer it wholesale, since I don't know you well (yet), and I've seen useful, important crates get orphaned and it's a pain in the butt to do anything about it.

I do understand it, no worries! I just saw that no one really put any work into the crate for a long time and I wanted to bring it to a usable state again.

Don't expect anything this month from me though, I am quite busy right now with work/uni. I will open a PR at the start/mid august once stuff has settled down a little bit for me and I have more time to work on it .

from aseprite.

PSteinhaus avatar PSteinhaus commented on May 30, 2024 1

I’d be ok with that as well.
Back then I mainly started working on ggez because I used it and tried to use it in ways that where either not possible yet or especially prone to exposing some certain nasty bugs. That motivated me greatly to improve things, so I think I can understand your motivation and would love to have you as a maintainer on this.

I’d probably like to look over at least one PR of you before adding you.
Luckily, you already made one that I was just too lazy/concerned with other rl problems to review yet!
I’ll try to make space for it later today and then give my ok.

from aseprite.

PSteinhaus avatar PSteinhaus commented on May 30, 2024 1

@tversteeg Congratulations! You just became maintainer!
Sorry again for being so slow. I lost sight of it and somehow got no / missed all email notifications...

@icefoxen crate ownership is still yours. Maybe consider whether you want to add him, or release new versions yourself, hehe ^^

@tversteeg I currently only gave you direct access to this repo alone. As we are currently looking for new maintainers for ggez in general I got to ask though: Would you perhaps be interested? : )

from aseprite.

tversteeg avatar tversteeg commented on May 30, 2024 1

Awesome, thanks! I am willing to be a co-maintainer for ggez, I won't actively develop on it since I don't use it myself, but I will be able to merge maintenance PRs and check that they adhere to the coding standards. I'm not sure if that's what you're looking for in another maintainer, but that's unfortunately all that I can realistically offer.

from aseprite.

icefoxen avatar icefoxen commented on May 30, 2024 1

Great, thanks! And thanks for poking me on reddit, github notifications kinda get lost in the noise sometimes. 😅 I'll add you as a crate owner but also keep myself on there just so the bus number is >1.

There's some account issues adding you as the crates.io owner but let's just resolve those in the reddit conversation.

from aseprite.

icefoxen avatar icefoxen commented on May 30, 2024

Oho. Sorry for the late response, but I like your moxie. I basically made this a few years ago for an internal project and haven't touched it since, as you've noticed.

I like your proposed plan. How about you make PR's for the changes/features you want to add and we can work together to release a 0.2 version? The question you should ask yourself for getting ownership/publish access for github crates.io is, "do I really want to maintain this crate long term? Really?". If you do, I'd happily make you co-owner on this crate.

I would rather not transfer it wholesale, since I don't know you well (yet), and I've seen useful, important crates get orphaned and it's a pain in the butt to do anything about it. But it would definitely be nice to have someone else to share maintenance with, and still have a backup in case one or the other of us falls off the face of the internet.

from aseprite.

icefoxen avatar icefoxen commented on May 30, 2024

No problem, and good luck with work/uni. Really this crate is mainly data structures and serde bindings, so I don't think there will be a lot of maintenance needed once it works. Feel free to make PR's for whatever you want, though it'd be nice to have at least some reference data/example files to verify it works correctly. I should go back and improve some of the unit tests and such as well anyway, add code coverage, that sort of thing. Once that's done and we're happy with a 0.2 version I'd be happy to give you co-maintainership so one of us is able to handle/fix things even if the other isn't available.

from aseprite.

tversteeg avatar tversteeg commented on May 30, 2024

I would like to take on this role as well, since I'm apparently the biggest consumer of this crate. I'm currently making a pixel-based GUI library which will make heavy use of this crate. Because of that, I would like to properly modernize the library and release 0.2.0, so I can use the slice information in the metadata.

I think I'm in a good position to fill the role of co-maintainership for this crate. The scope of it is pretty small, I'm directly using it and I don't mind maintaining these type of libraries.

from aseprite.

svenstaro avatar svenstaro commented on May 30, 2024

I'd definitely be ok with bringing on more maintainer to ggez. @PSteinhaus what do you think?

from aseprite.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.