Code Monkey home page Code Monkey logo

Comments (3)

greggman avatar greggman commented on May 19, 2024

You're not adding the vectors, you're adding the direction of the vectors. In other words you add the normalized vectors, not the vectors themselves to get the halfVector.

from webgl-fundamentals.

greggman avatar greggman commented on May 19, 2024

The simplest update might just be to change it from

If we know the direction from the surface of our model to the light (which we do since we just did that). And if we know the direction from the surface to view/eye/camera, which we can compute, then we can add those 2 vectors and normalize them to get the halfVector

to

If we know the direction from the surface of our model to the light (which we do since we just did that). And if we know the direction from the surface to view/eye/camera, which we can compute, then we can add those 2 directions and normalize the result to get the halfVector. Note: by direction I mean the normalized values of the 2 vectors, surface2View and surface2Light.

Or something simple like that. I don't want to add paragraphs of text if it's not needed.

from webgl-fundamentals.

trusktr avatar trusktr commented on May 19, 2024

I think

Note: by adding those 2 directions I mean adding the normalized values of each of the 2 vectors, surface2View and surface2Light.

sounds good, with the rest the same. 👍

from webgl-fundamentals.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.