TypeError: Cannot read property 'type' of undefined about amdclean HOT 12 CLOSED

Can you post a minimal example reproducing the error? That would make debugging it much easier

from amdclean.

I will investigate this and will hopefully have an answer by the weekend (busy work schedule this week).

from amdclean.

Hey sorry, I've also had a really busy work week and haven't had time to create a minimal test case. There is quite a lack of debugging output so in order to give a minimal example I'd essentially have to go through and debug the code myself, which I would have loved to do but I don't have time at the moment. I can say that this specific file causes the error to occur:

https://github.com/mobify/mobifyjs/blob/v2.0/build/mobify.js

from amdclean.

@jansepar Would you mind updating to the 0.3.1 version and let me know if it fixes your issue? Thanks!

from amdclean.

After looking through the Mobify code, there looks like there is only one weird block:

require(["mobifyjs/utils", "mobifyjs/capture", "mobifyjs/resizeImages", "mobifyjs/jazzcat", "mobifyjs/unblockify", "mobifyjs/cssOptimize", "mobifyjs/external/picturefill"], function(Utils, Capture, ResizeImages, Jazzcat, Unblockify, CssOptimize) {
    var Mobify = window.Mobify = window.Mobify || {};
    Mobify.Utils = Utils;
    Mobify.Capture = Capture;
    Mobify.ResizeImages = ResizeImages;
    Mobify.Jazzcat = Jazzcat;
    Mobify.CssOptimize = CssOptimize;
    Mobify.Unblockify = Unblockify;
    Mobify.api = "2.0"; // v6 tag backwards compatibility change
    return Mobify;

}, undefined, true);

Is there a reason you are passing undefined and true to your require() method?

from amdclean.

@gfranko yep! Those arguments are relName and forceSync that are used for the almond.js loader I'm using. You can look more into it here: https://github.com/jrburke/almond/blob/master/almond.js#L321

Ideally I'd like to use requirejs/AMD for dependancy management when building the library, but I'd rather not have a loader file (almond.js) at all. Hoping amdclean can give me that ideal scenario :)

from amdclean.

I think if you just take out the undefined and true parameters, then AMDClean should already work for you =)

I'll look into why the extra parameters are not working with AMDClean.

from amdclean.

This is now fixed in version 0.3.2. Let me know if you have any other issues!

from amdclean.

Thanks! I'll give it a shot. Just a heads up 0.3.2 has not been deployed to npm yet.

from amdclean.

For some reason the npm site still shows 0.3.1, but if you check the latest version number with npm show amdclean version, then it shows that 0.3.2 is the latest version.

from amdclean.

Ah, cool. I just tried it out and it's working great! Thanks for all your help :)

from amdclean.

I'm glad we got this sorted out, sorry it took so long!

from amdclean.