Ignore @ for tags if part of an URL (such as Mastodon user/posts links) about gtg HOT 6 CLOSED

I don't see such test in https://github.com/getting-things-gnome/gtg/blob/master/tests/core/test_tag.py nor https://github.com/getting-things-gnome/gtg/blob/master/tests/core/test_tag2.py (I'm not even sure why there is two and they are named like that). I'm waiting for #1036 to be merged, I hope I can make some regex tag tests then.

from gtg.

One should tweak TAG_REGEX variable:

https://github.com/getting-things-gnome/gtg/blob/master/GTG/gtk/editor/taskview.py#L46

Currently it is set as:

\B\@\w+(\.*[\-\w+\+\%\$\\(\)\[\]\{\}\^\=\/\*])*

and simple check on https://regex101.com/ confirms the problem.

from gtg.

Replacing \B with negative lookbehind assertion (?<!\/) seems to do the trick, but more testing is welcome.

from gtg.

@nekohayo BTW do we have tests for checking regex tag matches? it would be useful to keep an eye on this important feature.

from gtg.

(?<!\/|\w) in place of \B works even better, because it skips not only https://wikis.world/@Poslovitch/111121879906550235 , but also http://username:[email protected] (with any word character before @, not just slash).

from gtg.

I have no idea if there are automated tests for the regexes, but if there aren't, there should be, indeed!

from gtg.