Code Monkey home page Code Monkey logo

Comments (4)

nekohayo avatar nekohayo commented on August 19, 2024

Regarding point no.3, I believe the current code validated for non-empty names, but not non-empty queries ; in think it should also check for that (and ideally do some more advanced checks for valid syntax or something, but I don't know exactly what criteria to apply there)

from gtg.

nekohayo avatar nekohayo commented on August 19, 2024

For your problem no2, I bet there is some relationship between this and #1005 (for tags)...

from gtg.

kocio-pl avatar kocio-pl commented on August 19, 2024

Regarding 2, if I add explicit definition for ds.saved_searches.remove, the problem is reverse - search is deleted from the list immediately, but after restart it returns (so it's not saved probably):

def remove(self, search_id: uuid4) -> None:
    """Remove saved search"""
  
    search = self.lookup[search_id]
    self.data.remove(search)
    pos = self.model.find(search)
    self.model.remove(pos[1])

I'm not a coder, so this might be broken in many ways, but this is what I thought might work at least. It's just some input which could help debug the problem.

from gtg.

nekohayo avatar nekohayo commented on August 19, 2024

Related: #1048

from gtg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.