Code Monkey home page Code Monkey logo

Comments (7)

esarbanis avatar esarbanis commented on May 30, 2024 1

Hello everyone! Let me shed some light on this issue. The last 2 Flutter minor versions are introducing breaking changes:

  • 3.16.x uses material 3 by default, this breaks our golden tests and therefore our UI components are compromised. We are working on fixing them in our v8.0.0 beta version.
  • 3.19.x breaks the use of showBottomSheet, which is an easy fix, but doesn't really matter as in order to get to this version you will also have t use Material3. This fix is in PR for v8.0.0 beta version.

Unfortunately, for the above reasons we cannot "officially" support 3.19 in our stable version yet. I know it is frustrating, and we are working on stabilizing our beta version soon.

from stream-chat-flutter.

pixnbit avatar pixnbit commented on May 30, 2024

Happening on Flutter 3.19. (I had to downgrade to 3.16.9 because of this)

from stream-chat-flutter.

dagyu avatar dagyu commented on May 30, 2024

If you want to made this running also in flutter 3.19 just edit the file in your local cache (in this case in ../../../.pub-cache/hosted/pub.dev/stream_chat_flutter-5.3.0/lib/src/bottom_sheets/stream_channel_info_bottom_sheet.dart) and remove all <T> from this lines:

PersistentBottomSheetController<T> showChannelInfoBottomSheet<T>({
required BuildContext context,
required Channel channel,
Color? backgroundColor,
double? elevation,
BoxConstraints? constraints,
AnimationController? transitionAnimationController,
Clip? clipBehavior = Clip.hardEdge,
ShapeBorder? shape = _kDefaultChannelInfoBottomSheetShape,
void Function(Member)? onMemberTap,
VoidCallback? onViewInfoTap,
VoidCallback? onLeaveChannelTap,
VoidCallback? onDeleteConversationTap,
VoidCallback? onCancelTap,
}) =>
showBottomSheet<T>(
context: context,
backgroundColor: backgroundColor,
elevation: elevation,
shape: shape,
clipBehavior: clipBehavior,
constraints: constraints,
transitionAnimationController: transitionAnimationController,
builder: (BuildContext context) => StreamChannelInfoBottomSheet(
channel: channel,
onMemberTap: onMemberTap,
onViewInfoTap: onViewInfoTap,
onLeaveChannelTap: onLeaveChannelTap,
onDeleteConversationTap: onDeleteConversationTap,
onCancelTap: onCancelTap,
),
);

after this change it will work again and your file should seems like:

PersistentBottomSheetController showChannelInfoBottomSheet({
  required BuildContext context,
  required Channel channel,
  Color? backgroundColor,
  double? elevation,
  BoxConstraints? constraints,
  AnimationController? transitionAnimationController,
  Clip? clipBehavior = Clip.hardEdge,
  ShapeBorder? shape = _kDefaultChannelInfoBottomSheetShape,
  void Function(Member)? onMemberTap,
  VoidCallback? onViewInfoTap,
  VoidCallback? onLeaveChannelTap,
  VoidCallback? onDeleteConversationTap,
  VoidCallback? onCancelTap,
}) =>
    showBottomSheet(
      context: context,
      backgroundColor: backgroundColor,
      elevation: elevation,
      shape: shape,
      clipBehavior: clipBehavior,
      constraints: constraints,
      transitionAnimationController: transitionAnimationController,
      builder: (BuildContext context) => StreamChannelInfoBottomSheet(
        channel: channel,
        onMemberTap: onMemberTap,
        onViewInfoTap: onViewInfoTap,
        onLeaveChannelTap: onLeaveChannelTap,
        onDeleteConversationTap: onDeleteConversationTap,
        onCancelTap: onCancelTap,
      ),
    );

from stream-chat-flutter.

Ignacio1110 avatar Ignacio1110 commented on May 30, 2024

I faced the same problem.

from stream-chat-flutter.

justinschier avatar justinschier commented on May 30, 2024

This is also stopping me from upgrading to Flutter 3.19.2

from stream-chat-flutter.

github-actions avatar github-actions commented on May 30, 2024

This issue is stale because it has been open for 20 days with no activity.

from stream-chat-flutter.

github-actions avatar github-actions commented on May 30, 2024

This issue was closed because it has been inactive for 7 days since being marked as stale.

from stream-chat-flutter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.