Code Monkey home page Code Monkey logo

Comments (6)

cmanallen avatar cmanallen commented on June 15, 2024

Context: mobile replays send video events. These video events are fetched independently of the RRWeb recording data. However, they're also stored separately.

from sentry.

cmanallen avatar cmanallen commented on June 15, 2024

Option. On download call json.loads(downloaded_data), loop through the [events], extract the breadcrumb events and return, or extract the RRWeb events and return.

This would be backwards compatible but expensive (relative to: recv data -> stream to client).

from sentry.

cmanallen avatar cmanallen commented on June 15, 2024

Option: On upload, store breadcrumb events and RRWeb events independently of one another. On request lookup the {filename}-rrweb file or the {filename}-breadcrumbs file based on the endpoint or query parameter. This improves performance on the API (recv data -> stream to client). Older files would not be split and would either need a backwards compatible fallback (following the option above) or the client would have to fetch the legacy files and split them locally.

This doubles the number of files we need to upload which will have an impact on consumer throughput. We could adopt an approach similar to my hackweek project to optimize this.

from sentry.

bruno-garcia avatar bruno-garcia commented on June 15, 2024

We'll first investigate and confirm the root cause before going ahead with this change which is significant.

from sentry.

jas-kas avatar jas-kas commented on June 15, 2024

Example crashes - https://github.com/getsentry/team-replay/issues/399

from sentry.

bruno-garcia avatar bruno-garcia commented on June 15, 2024

Created a ticket specific to the investigation so we don't need ot commit to this solution:

from sentry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.