Is there an existing issue for this? <li class="

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

<a class="user-mention notranslate" data-hovercard-type="user" data-hover

If I init sdk this way: <div class="highlight highlight-source-ts notranslate posi

Mixing node and edge instrumentations causes webpack errors about sentry-javascript HOT 8 CLOSED

r34son commented on June 4, 2024

Mixing node and edge instrumentations causes webpack errors

from sentry-javascript.

Comments (8)

lforst commented on June 4, 2024 1

It should be fine to inti the edge SDK with a dynamic import. If possible, try to leave the node SDK init synchronous.

from sentry-javascript.

lforst commented on June 4, 2024 1

This is actually a good insight. Thanks for raising this! I see this as a documentation issue we need to resolve.

from sentry-javascript.

r34son commented on June 4, 2024

Problem with @sentry/profiling-node integration

from sentry-javascript.

JonasBa commented on June 4, 2024

@r34son profiling will not work without a nodejs API, so I would recommend you remove this for edge runtime. I will need to look at how and if it's even possible to support this. I'm sorry if this isnt of much help.

from sentry-javascript.

r34son commented on June 4, 2024

@r34son profiling will not work without a nodejs API, so I would recommend you remove this for edge runtime. I will need to look at how and if it's even possible to support this. I'm sorry if this isnt of much help.

It is actually the problem, because of one chunk emited for both runtimes

from sentry-javascript.

r34son commented on June 4, 2024

Thanks!

from sentry-javascript.

r34son commented on June 4, 2024

If I init sdk this way:

import { init } from '@sentry/nextjs';
import { nodeProfilingIntegration } from '@sentry/profiling-node';
import { SENTRY_CAPTURE_RATE, SENTRY_DSN } from 'sentry.constants.mjs';

export async function register() {
  if (process.env.NEXT_RUNTIME === 'nodejs') {
    init({
      dsn: SENTRY_DSN,
      debug: false,
      tracesSampleRate: SENTRY_CAPTURE_RATE,
      profilesSampleRate: SENTRY_CAPTURE_RATE,
      environment: process.env.ENV,
      integrations: [nodeProfilingIntegration()],
    });
  }
  if (process.env.NEXT_RUNTIME === 'edge') {
    await import('./instrumentation.edge');
  }
}

It somehow fails in turbopack:

from sentry-javascript.

r34son commented on June 4, 2024

Only works importing @sentry/profiling-node dynamically:

import { init } from '@sentry/nextjs';
import { SENTRY_CAPTURE_RATE, SENTRY_DSN } from 'sentry.constants.mjs';

export async function register() {
  if (process.env.NEXT_RUNTIME === 'nodejs') {
    const { nodeProfilingIntegration } = await import('@sentry/profiling-node');
    init({
      dsn: SENTRY_DSN,
      debug: false,
      tracesSampleRate: SENTRY_CAPTURE_RATE,
      profilesSampleRate: SENTRY_CAPTURE_RATE,
      environment: process.env.ENV,
      integrations: [nodeProfilingIntegration()],
    });
  }
  if (process.env.NEXT_RUNTIME === 'edge') {
    await import('./instrumentation.edge');
  }
}