SerializationHelper.DecimalToBinary does not work correctly about eos-sharp HOT 5 CLOSED

I don't fallow your logic on what are you trying to convert and whats wrong.

SerializationHelper.DecimalToBinary is the same implementation from eosjs2 and converts a string to a byte[] representation in a given size.

Can you give more details on what you are trying to test? Function call?

string doubleStr = "10001";
var doubleBytes = SerializationHelper.DecimalToBinary(8, doubleStr);
returns: 17 39 0 0 0 0 0 0

var doubleBytes2 = BitConverter.GetBytes(Convert.ToUInt64(doubleStr));
returns: 17 39 0 0 0 0 0 0

same for the 16 bytes version...

Even thought I find your pull request a more cleaner solution is not as generic as the eosjs2 version. Not that we need anything othern than 4, 8, 16 bytes storage size.

from eos-sharp.

Strange - I wonder then why my result is

string doubleStr = "10001";
var doubleBytes = SerializationHelper.DecimalToBinary(8, doubleStr);
returns: 17 0 0 0 0 0 0 0

from eos-sharp.

Can you execute this on your target machine?
bool le = BitConverter.IsLittleEndian;

What is the result?

What is your OS and hardware specifications?

from eos-sharp.

The result is true.

Windows 10 Professional, 64 bit

from eos-sharp.

I'm using same OS and the same littleendianess this may be hardware related or you are using other version of the netstandard. Other than that I can't reproduce this behavior.

Created some unit tests for this you may try the different approaches.

Going to close this issue but feel free to repopen if you got more detail.

from eos-sharp.