Comments (8)
Sorry for the issues you had w/ the Vagrant box, I opened #1480 to track the work on the dev guide.
from redash.
@clarkbw The developer guide has been updated along with new documentation on how to use Docker for easy setup of your dev environment (instead of Vagrant).
https://redash.io/help-onpremise/dev/guide.html
Also, once Mozilla will have recent version of Redash deployed on s.t.m.o, you will be able to use it instead of running things locally: https://redash.io/help-onpremise/dev/remote-server.html (while only having frontend stuff run locally).
from redash.
What do you think about using the following solution for this? code via blog I'll need to do some testing that this approach still works with most adblockers.
(function(){
var test = document.createElement('div');
test.innerHTML = ' ';
test.className = 'adsbox';
document.body.appendChild(test);
window.setTimeout(function() {
if (test.offsetHeight === 0) {
document.body.classList.add('adblock');
}
test.remove();
}, 100);
I was thinking that somewhere in the navbar, navbar-right
, the test element displays if you have adblock enabled otherwise remains hidden. This code should all be async and on a timeout so it doesn't block anything.
What do you think about this approach?
from redash.
If it works, sounds good to me. Need to figure out how to display the message to the user without annoying him. :) But maybe a warning icon in the navbar that when clicked will explain that you he disable AdBlock.
I only wonder if we should allow the user to dismiss the message without disabling adblock? And if we do, how to store this setting?
from redash.
If it works, sounds good to me. Need to figure out how to display the message to the user without annoying him. :) But maybe a warning icon in the navbar that when clicked will explain that you he disable AdBlock.
Do you think a popup or other page is the right solution here? I don't know what the most consistent system would be here.
I only wonder if we should allow the user to dismiss the message without disabling adblock? And if we do, how to store this setting?
I was wondering this as well. If we did some kind of icon with a popup and allowed people to ignore it I think we'd need to save that either in cookies or profile db.
from redash.
Do you think a popup or other page is the right solution here? I don't know what the most consistent system would be here.
Popup seemed right to me as you want to explain to the user what's the problem but not take too much screen real estate for it. Also thought about the fact that the user might fix/dismiss it on one browser but have it again in another.
Considering that it's a non issue for most, how about we show a small message in the footer when we detect ad blocking:
⚠️ You seem to have ad blocking extension enabled. ❔
And when you hover the ? it will show a bubble with explanation?
from redash.
Considering that it's a non issue for most, how about we show a small message in the footer when we detect ad blocking:
Sounds good.
from redash.
Having trouble getting started with Vagrant on the Mac. Spent too much time there, will have to come back to this later. Let me know if there are updated docs somewhere.
from redash.
Related Issues (20)
- facing internal server error after clicking on queries option HOT 2
- Add generic OAuth2/OIDC authentication HOT 1
- Uncaught promise error in Edit Visualization Dialog Modal
- date parameter configuration in redash self hosting. HOT 3
- Redash does not connect to Microsoft SQL Azure HOT 2
- queury in queue issue
- SchedulerWorker doesn't refresh query HOT 1
- Redash can't refresh mongodb schema unless all collections are granted HOT 2
- How to customize data label in redash HOT 1
- Query Results Error When I Join Multitable
- How can I disable/hide filters in an embedded dashboard? HOT 1
- Problem with asset location server.css after setup on Ubuntu HOT 1
- Slack as Alert destination: URLs in messages posted to Slack are not clickable links HOT 1
- Downgrading then upgrading redash schemas doesn't work HOT 6
- DynamoDB Support (regression issue) HOT 2
- numberFormat and thousandsSep HOT 6
- How to add counter visualization clickable its is possible ? HOT 2
- Feature request: an installation script for Fedora! HOT 1
- Front end data type display exception HOT 7
- puppeteer issue with Apple Silicon chips HOT 19
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redash.