Comments (4)
👍
from contenttools.
Make sense.
I think we may run into the same complications discussed for adding start/stop events #31 - that the event system needs to be overhauled for ContentTools. I'm considering switching to native events but support seems to be sketch at the moment so I'd need to use deprecated interfaces to support for the target browser list currently.
from contenttools.
Native events are fine, but I don't think it's a required change. For me the main benefit would be a shorter syntax with editor.addEventListener
, but aside from that, I don't see any other benefits (let me know if there are others, I'm not a Javascript guru).
Why overhaul the event system?
from contenttools.
The ToolUI components now trigger apply
and applied
events (http://getcontenttools.com/api/content-tools#tool-ui) so it is possible to listen for these events now in the toolbox using:
editor.toolbox()._toolUIs['bold'].addEventListener('apply', function (ev) { ... });
So you can monitor the tools applied by the user and/or changes to the region (using ContentEdit events), what you can't do yet is bind events to the Tool static classes at this time (because they don't inherit from the ComponentUI class). However I'm intending to review this for the next release along with adding additional events now the new event model is in place so this discussion will move to a new issue.
from contenttools.
Related Issues (20)
- Save issue - saves fine, but won't allow a second "save" HOT 5
- Making CT compatible with CSP style-src set to 'self'
- Can't edit files that were included or read by php HOT 17
- Edit multiple paragraphs at once. HOT 2
- Is there a way to change the default tag output for normal html tags HOT 2
- Missing translation in /src/scripts/ui/dialogs/table.coffee
- Problem update image classes HOT 5
- Build files to use dynamic import in pure javascript HOT 1
- How to use assign ? HOT 2
- Hot to keep style attributes on save.
- Support for Sass >= 1.33 HOT 11
- npm install failed HOT 2
- Feature: Support drag & drop of images
- The image uploader HOT 2
- Inspector bar doesn't show embedded HTML elements when wrapped with paragraph HOT 1
- Line breaks not saving
- Add class to a link
- Lazy loading of images
- Source code edit? Insert <script> tag HOT 3
- The part in italics is not the right one HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from contenttools.