Code Monkey home page Code Monkey logo

Comments (8)

drnasin avatar drnasin commented on August 24, 2024 1

@CSixtyFour so there's no cross posting - getgrav/grav#1827 (comment) - the guys are aware and baffled :)

from grav-plugin-sitemap.

humhann avatar humhann commented on August 24, 2024

Seems that both work:
http://localhost/sitemap
https://localhost/sitemap

Would it make sense that http version redirects to https when ForceSSL is enabled?

from grav-plugin-sitemap.

CSixtyFour avatar CSixtyFour commented on August 24, 2024

@drnasin I had this same issue because I've got SSL offloading and Grav doesn't take this into account. I've raised a PR against Grav which resolved the issue for me getgrav/grav#1827
HTH

from grav-plugin-sitemap.

drnasin avatar drnasin commented on August 24, 2024

@CSixtyFour How did yo solve this? On my production server sitemap still generates http instead of https...locally it's ok...weird...

from grav-plugin-sitemap.

CSixtyFour avatar CSixtyFour commented on August 24, 2024

@drnasin
For me it wasn't the sitemap itself that was the issue but Grav core uri coming through incorrectly (either http or https://url.com:80) which getgrav/grav#1827 fixed for me. Its just two small code blocks so I've been manually patching after updates until that PR pulls through

from grav-plugin-sitemap.

drnasin avatar drnasin commented on August 24, 2024

@CSixtyFour Yeah I saw your pull request. Just what I need. I didn't want to mess with the core files. is there a reason why it's still not released?

from grav-plugin-sitemap.

CSixtyFour avatar CSixtyFour commented on August 24, 2024

I have no idea @drnasin maybe it hasn't been tested by the Grav core team yet or maybe there's a better way to achieve the same result. I think there's been about 3 releases since that PR so manual updating is a pain but not really a hassle.

from grav-plugin-sitemap.

NicoHood avatar NicoHood commented on August 24, 2024

This has been fixed, the issue can be closed.

from grav-plugin-sitemap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.