Code Monkey home page Code Monkey logo

Comments (4)

triztian avatar triztian commented on July 30, 2024

I've submitted a pull request that fixes this issue in the plugin. But to address this in the flutter code I've created the following overriding class:

import 'package:logging/logging.dart';
import "package:datadog_flutter/datadog_flutter.dart";

class PDatadogFlutter extends DatadogFlutter {
  PDatadogFlutter({
    String clientToken,
    String serviceName,
    String loggerName,
    bool bindOnRecord = true,
    String environment = 'development',
  }) :  super(
      clientToken: clientToken,
      serviceName: serviceName,
      loggerName: loggerName,
      bindOnRecord: bindOnRecord,
      environment: environment
  );

  @override
  Future<void> log(String logMessage, Level logLevel,
      {Map<String, dynamic> attributes}) async {
    if (attributes == null) {
      return super.log(logMessage, logLevel, attributes: {}); //providing an empty prevents the exception
    }

    return super.log(logMessage, logLevel, attributes: attributes);
  }
}

You can then replace the DatadogLogger type with this one to handle the case when attributes argument is null.

DatadogFlutter ddLogger = PDatadogFlutter(
   clientToken: 's3cr37',
   serviceName: 'myapp',
   environment: 'development'
);

The "P" stands for "patched". Hope it helps someone!

from datadog_flutter.

tshedor avatar tshedor commented on July 30, 2024

@triztian reading your PR, the Flutter code should not be necessary to include, right?

from datadog_flutter.

triztian avatar triztian commented on July 30, 2024

@tshedor you are correct it is not needed, the flutter code is just my workaround until the PR was accepted or a different change addressed the issue. The code is a hack around it without having to change the plugin (kotlin/swift code) to build locally.

from datadog_flutter.

tshedor avatar tshedor commented on July 30, 2024

@triztian super. I'm going to close this issue then since #3 has been merged and released on pub dev. Thanks again for the contribution

from datadog_flutter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.