Comments (7)
Hey @jdickey, I have accepted your pull request, as you may have noticed :) but it has a problem.
I'm under Linux and it's trying to open the browser using the Mac open command.
I have updated the code, locally, like this:
function _opengit_open()
{
local open_cmd='huh?'
if [ -z `echo $MACHTYPE | grep linux` ]; then
open_cmd='open'
else
open_cmd='xdg-open'
fi
$open_cmd $1
}
For a reason, I don't understand, the line bellow is not working here
if [ -n `echo $MACHTYPE | grep darwin` ]; then
It's working, can you take a look at it please? I'm not a bash master :)
from git-open.
gerep, sorry I got buried with work for a couple of weeks; investigating 😃
What is your $MACHTYPE
value?
from git-open.
@jdickey No worries, we have time :)
My $MACHTYPE is x86_64-unknown-linux-gnu
from git-open.
Hey @jdickey how you doing? Working a lot I guess 😄
Any updates o this issue?
from git-open.
Sorry, @gerep; was out of action most of last week. Spent almost 3 days in hospital. I'll get on it Friday and Saturday this week; attempting to un-bury myself from work now. Sorry for being so slow.
from git-open.
Hey @jdickey I'm closing this issue because I've made some tests under Linux and Mac and it's working great.
If you think of another improvement please make a pull request.
Thanks a lot for your help.
from git-open.
@gerep Thanks!
from git-open.
Related Issues (11)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git-open.