Code Monkey home page Code Monkey logo

Comments (3)

rohan-sawhney avatar rohan-sawhney commented on July 17, 2024

There is a namespace bff for most files in the project, that should help avoid conflicts right? Or is it just the name of the file that's somehow conflicting with the build process?

from boundary-first-flattening.

aschier avatar aschier commented on July 17, 2024

Yes, the namespace helps a lot inside the code, but when I try to include mesh.h or other common names, the filename is not unique and the file which comes first in the include path is used. Grouping the own headers in a directory helps to avoid such conflicts.
Especially names like Common.h easily conflict with others, so it is nice when libraries use a subfolder which clearly separates the file from other headers.

I am currently working on extending the CMake files with exported targets and install targets for the library, so it can easily be linked with other projects. I will push the changes when I verified that it can be linked in our projects.
Note: I am on holiday from now to the mid march, and I will continue working on this afterwards.

from boundary-first-flattening.

aschier avatar aschier commented on July 17, 2024

I currently moved Mesh to BFFMesh (aschier@1a95e86) to avoid the problems with our header files. Our future additions to the code will depend on the new name.

I would really appreciate when the headers would be moved into a bff subfolder to avoid any future conflicts with the filenames. When you agree to merge it, I can implement it and send a pull request for the change.

from boundary-first-flattening.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.