Comments (3)
There is a namespace bff
for most files in the project, that should help avoid conflicts right? Or is it just the name of the file that's somehow conflicting with the build process?
from boundary-first-flattening.
Yes, the namespace helps a lot inside the code, but when I try to include mesh.h
or other common names, the filename is not unique and the file which comes first in the include path is used. Grouping the own headers in a directory helps to avoid such conflicts.
Especially names like Common.h
easily conflict with others, so it is nice when libraries use a subfolder which clearly separates the file from other headers.
I am currently working on extending the CMake files with exported targets and install targets for the library, so it can easily be linked with other projects. I will push the changes when I verified that it can be linked in our projects.
Note: I am on holiday from now to the mid march, and I will continue working on this afterwards.
from boundary-first-flattening.
I currently moved Mesh to BFFMesh (aschier@1a95e86) to avoid the problems with our header files. Our future additions to the code will depend on the new name.
I would really appreciate when the headers would be moved into a bff
subfolder to avoid any future conflicts with the filenames. When you agree to merge it, I can implement it and send a pull request for the change.
from boundary-first-flattening.
Related Issues (20)
- seeking surface model with holes HOT 3
- Port to wasm for web
- Mesh has isolated vertex HOT 1
- Include GLFW as Dependency HOT 2
- Concepts in the project HOT 1
- Compile with emscripten question HOT 2
- UV Overlapping problem? HOT 2
- AdjacencyTable uses a slow data structure HOT 1
- `std::vector<bool>` has unfortuante and unexpected implementation HOT 1
- Half edge mesh operations cannot be inlined HOT 1
- Mesh has non manifold vertices HOT 2
- Mac Command Line error - Access Denied HOT 2
- non-manifold edges warning when holes/multiple components HOT 1
- README needs an update for the C++ interface HOT 2
- Asymmetric result after flattening HOT 7
- Vector subscript is out of range exception. PolygonSoup.cpp. HOT 4
- About flattening to a rectangle with specified aspect ratio HOT 3
- How to output area distortion from an app HOT 2
- feat: Export error/quality measures
- Parallel unwrapping
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from boundary-first-flattening.