Iterator problem in MeshIO.buildMesh about boundary-first-flattening HOT 4 CLOSED

Agree. The mesh related code is doing a lot of things like cache iterators, and then modify the vector, then keep using the cached iterators. The code can run because it always preallocates big enough memory and only insert elements at the end of a vector. And Take the HalfEdge class for example, it uses vector iterators as class members, which is a very dangerous practice. Probably there is a lot to refactor.

from boundary-first-flattening.

@whiteeat yes, there is definitely room for improvement here. @kentbarber updating "end" might dynamically increase the length of the loop. I don't think this has any unindented consequences on the algorithm itself, but not sure if this is something you would like to do to squash the warning.

from boundary-first-flattening.

@rohan-sawhney if you need to iterate over original elements in halfEdges, better to use indexes instead of iterators. After insertian vector reallocates memory and end iterator do not point to valid memory and throw "Vector Iterators Incompatible" exeption in debug mode.

from boundary-first-flattening.

@Lishen1 thanks for the suggestion, the plan is to revamp the halfEdge data structure for the next release.

from boundary-first-flattening.