Code Monkey home page Code Monkey logo

Comments (24)

aishpant avatar aishpant commented on May 24, 2024

I am interested in working on this issue! But I have not been able to reproduce it.
Could you help me out here?

from geometry.

desyncr avatar desyncr commented on May 24, 2024

Sure thing. As soon as I can I'll give you further information (OS, terminal etc).

from geometry.

desyncr avatar desyncr commented on May 24, 2024

OS: OS X Yosemite, 10.10.5
Terminal: iTerm2 Build 3.0.12 & Terminal.app Version 2.5.3 (343.7)
zsh: zsh 5.3 (x86_64-apple-darwin14.5.0)

Anyways, it happened with zsh 5.2 as well, probably with other versions too.

from geometry.

desyncr avatar desyncr commented on May 24, 2024

Step to reproduce:

  • Open a terminal
  • Run sleep 10

Expected results:

  • Terminal window title should display: sleep @ ~/path/to/current/directory

Results:

  • $COMMAND @ $CURR_DIR

Hope that helps!

from geometry.

frm avatar frm commented on May 24, 2024

By the way, it's currently working on my end.

screen shot 2016-12-16 at 12 26 26

It's iTerm nightly, by the way.

from geometry.

aishpant avatar aishpant commented on May 24, 2024

Works on my end too.
OS : macOS Sierra, 10.12.1
Terminal : Default terminal
zsh 5.2

I'll try on iTerm2.

from geometry.

frm avatar frm commented on May 24, 2024

@desyncr can you check if in the iTerm Preferences, under the Appearance tab, is there any option clicked on "Window & Tab Titles"?

from geometry.

frm avatar frm commented on May 24, 2024

Also, don't forget to check the "Terminal may set tab/window title" option under Preferences > Profiles > Terminal. Probably should add that to the docs.

from geometry.

desyncr avatar desyncr commented on May 24, 2024

May be I'm missing something, but remember it also does seem to work on Terminal.app.

screen shot 2016-12-16 at 9 38 41 am

screen shot 2016-12-16 at 9 39 03 am

from geometry.

frm avatar frm commented on May 24, 2024

Works on Terminal.app here as well.

from geometry.

frm avatar frm commented on May 24, 2024

macOS 10.12.1, zsh 5.3 (x86_64-apple-darwin16.1.0)

from geometry.

desyncr avatar desyncr commented on May 24, 2024

I guess then it's my set up in some way messing up with this. I'll take a look later today.

@aishpant It'll be better to look for other issues if you can't reproduce this one.

from geometry.

desyncr avatar desyncr commented on May 24, 2024

It seems it's all about this single line (check the single quotes). Not sure why you can't reproduce it thought.

from geometry.

desyncr avatar desyncr commented on May 24, 2024

@aishpant Are you up for this still? Let me know 👍

from geometry.

aishpant avatar aishpant commented on May 24, 2024

@desyncr sorry I haven't seen the issue here yet. I'll take something else.

from geometry.

desyncr avatar desyncr commented on May 24, 2024

Alright, I'll let it hang out a bit more for anyone interested and then take it if there is no one to look after it.

from geometry.

cnguy avatar cnguy commented on May 24, 2024

Hello, again! :) Just wanted to let you know that it works properly on my build and on both terminals as well.

El Capitan 10.11.6
zsh 5.0.8 & zsh 5.3.1 (one was an old built-in zsh, the other one is the updated one from homebrew)
Terminal.app 2.6.1
iTerm 2 3.0.12

Maybe a yosemite bug or something?

from geometry.

desyncr avatar desyncr commented on May 24, 2024

Could anybody try:

zsh -f
source /path/to/geometry/geometry.zsh
sleep 5

and check if the title is updated as expected? For me what happens is I see $COMMAND @ $CURR_DIR.

from geometry.

frm avatar frm commented on May 24, 2024

Able to reproduce that way:

screen shot 2016-12-23 at 12 37 10

from geometry.

desyncr avatar desyncr commented on May 24, 2024

It seems we're not properly setting PROMPT_SUBST. print documentation. Prompt expansion docs.

We probably should do setopt PROMPT_SUBST to make it work as expected anywhere.

from geometry.

frm avatar frm commented on May 24, 2024

@ChauTNguyen @aishpant any of you want to tackle this?

from geometry.

cnguy avatar cnguy commented on May 24, 2024

I'll try it. Where should setopt PROMPT_SUBST be placed though (for style purposes). Right now I have it under Misc configurations (line 35 of geometry.zsh).

from geometry.

desyncr avatar desyncr commented on May 24, 2024

I think it belongs inside the set up method prompt_geometry_setup below this line. As the global configuration section in geometry.zsh is meant for global variables, very little actual code show be placed there.

from geometry.

desyncr avatar desyncr commented on May 24, 2024

Fixed in #74

from geometry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.