Add custom context parameter for listener (the this problem in instance

Improve message-bus about geobricks-js HOT 2 CLOSED

geomatico commented on August 17, 2024

Improve message-bus

from geobricks-js.

Comments (2)

oscarfonts commented on August 17, 2024

An exampe where a callback function will loose the "this" context if it is not explicitly passed to listener:

define(["message-bus"], function(bus) {

    var Person = function(name) {
        this.name = name;

        this.getName = function() {
            return this.name;
        }

        bus.listen("rename", function(new_name) {
            this.name = new_name; // GAA!! "this" is not the instance context!
        });

    }

    return {
        createPerson: function(name) {
            return new Person(name);
        }
    }
});

Usage:

var factory = require("personFactory");
var person = factory.createPerson("Pepe");
person.getName(); // Returns "Pepe"

bus.send("rename", "Juan");
person.getName(); // GAA!! Won't be "Juan"!

from geobricks-js.

victorzinho commented on August 17, 2024

I like the third version (messagebus3.js). I'm not sure if we can run into browser compatibility problems if we get rid of jQuery. But we are simply using "apply", so that wouldn't be the case, I guess.

from geobricks-js.

Recommend Projects