Code Monkey home page Code Monkey logo

Comments (2)

jhdmpp avatar jhdmpp commented on August 28, 2024

Why?

from firefox-feedly-rss.

geoelectric avatar geoelectric commented on August 28, 2024

At the time, because Feedly quit supporting the older subscribe link, and that needed to be changed, though they did end up restoring support later.

Unfortunately, a poor choice I made regarding how the keys were added to the Firefox config store* made upgrading the extension risky, so I held off based on that and the additional requirement for code signing on newer versions.

Now, the problem is that I use platform APIs that aren't supported in the new extension model. var {Cc, Ci} = require("chrome"); is pretty much verbatim what they say the new model doesn't support, and is what I used to register the handler.

I am absolutely happy to have someone fork this, though they should fix the keystore issue I describe below, probably by saving off the ID of the handler that this add-on manages into an add-on-specific key.

And the behavior is available in Feedly Notifier, who did effectively fork this with his inclusion of the code. Assuming he doesn't run into a support issue with the chrome APIs being used, then that's where I'd go for this functionality.

  • I counted on my add-on being the only one manipulating the keys to add a handler by that exact name and URL, and it used that assumption to handle upgrade/disable/uninstall changes to the keystore. Someone else (Feedly Notifier) ended up including my add-on code directly in their add-on without changing that value--they had no way to know that was significant--so now we had two add-ons potentially manipulating those keys without knowledge of each other. That could cause a bunch of unexpected behavior on upgrade.

from firefox-feedly-rss.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.