Use an CacheProvider about geocoder HOT 12 CLOSED

Sure, actually I prefer CacheAdapter :)

from geocoder.

What do you prefer?

from geocoder.

I prefer an CacheProvider, which you can inject a CacheAdapter instance.

e.g.:

<?php
public function __construct(CacheInterface $cache, ProviderInterface $provider) {
    $this->_cache = $cache;
    $this->_provider = $provider;
}

from geocoder.

Can you be more precise ?

from geocoder.

Sure.
I prefer a CacheProvider, which you can inject an CacheAdapter (like MemcachedAdapter) and a another Provider (like YahooProvider). The CacheProvider tried to load the result from the CacheAdapter. If that not matched then load from the another Provider and store the result into the Cache.

from geocoder.

Oh, sweet!

Would you work on it ?

from geocoder.

Sure, I will work on it this evening.

from geocoder.

Fantastic!

from geocoder.

Would you remove the CacheLayer in the Geocoder class?

from geocoder.

No, not for the moment. Let's see your CacheProvider.

Oh, if you want, you can rename the Cache namespace to CacheAdapter (that was I understood the first time)

from geocoder.

Oh, do you have a use case for this adapter ?
I mean why dont you want to use the cache layer by registering a cache adapter ?

from geocoder.

I think, it's just not transparent and flexible enough.
And i would tried to keep the GeocoderClass as slim as possible.

from geocoder.