make adapter and locale protected in AbstractProvider about geocoder HOT 7 CLOSED

Well, not sure about that.

from geocoder.

Ping @havvg, still needed?

from geocoder.

Would be appreciated, yes!
I currently worked around it by replacing the provider by a custom one, which is hack-ish imho.

This at least solved the current use-case, but you cannot alter the locale of the provider :(

<?php

use Symfony\Component\DependencyInjection\ContainerInterface;

use Geocoder\HttpAdapter\HttpAdapterInterface;
use Geocoder\Provider\GoogleMapsProvider as BaseProvider;

class GoogleMapsProvider extends BaseProvider
{
    public function __construct(ContainerInterface $container, HttpAdapterInterface $adapter, $locale = null)
    {
        if ($container->isScopeActive('request') && $container->has('request')) {
            $locale = $container->get('request')->getLocale();
        }

        parent::__construct($adapter, $locale);
    }
}

from geocoder.

@havvg wanna write a PR?

from geocoder.

Yeah, will do!

from geocoder.

I'm currently writing the patch, but the test suite is failing (without changes): https://travis-ci.org/havvg/Geocoder/jobs/3280917

Does it make sense to actually issue requests to the providers backends?
Imho it's not actually testing the unit under test and allows glitches just like the current one to appear, although nothing might actually be broken within the library.

from geocoder.

@havvg don't worry.

from geocoder.