access levels not appropriate for data members about g2s HOT 6 CLOSED

I have sth to share, so I used several public here. I changed all unnecessary public.

from g2s.

Done

from g2s.

The data members were changed to default [package] access level. The package access level is discouraged. These data member should all be made private:
BlastDataBase db;
int matches;
int ensemblFileCount;
If access is needed outside of the class, add get() methods.

from g2s.

Done

On Thu, Aug 11, 2016 at 11:05 AM, Robert Sheridan [email protected]
wrote:

Assigned #26 https://github.com/cBioPortal/pdb-annotation/issues/26 to
@juexinwang https://github.com/juexinwang.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cBioPortal/pdb-annotation/issues/26#event-752885733,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADL7zDwwtdSQoLVSYftgPCMh4q-vCo5Cks5qe0g1gaJpZM4JY4OI
.

from g2s.

I changed to private, add set and get functions

from g2s.

Ok, closing issue ... but I did notice that Logger log is also not marked as access level private. If you get a chance, fix that one too.

from g2s.