Code Monkey home page Code Monkey logo

Comments (4)

pslh avatar pslh commented on July 30, 2024

I think we have two distinct and inconsistent checks for "area too large" in the UI and the backend:

if ( $scope.selectedRegion[0].tot_grid_count < 300000) {

https://github.com/gem/oq-platform/blob/master/openquakeplatform/openquakeplatform/exposure/views.py#L86

https://github.com/gem/oq-platform/blob/master/openquakeplatform/openquakeplatform/exposure/views.py#L123

I suspect that the backend value of 100k is probably safer: users on a slow line will probably have trouble downloading the gridded data for 300k cells. Reassigning to Ben.

from oq-platform.

ptormene avatar ptormene commented on July 30, 2024

Thank you Paul. That's what I was suspecting. Perhaps we should define the threshold only once, in a shared file, to avoid this kind of inconsistency.

from oq-platform.

daniviga avatar daniviga commented on July 30, 2024

Personally I would like to have a setting in the local_settings.py. It shouldn't be a big deal.

from oq-platform.

pslh avatar pslh commented on July 30, 2024

I agree, we should have a single value and it should be configurable via local settings.

from oq-platform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.