Code Monkey home page Code Monkey logo

Comments (6)

sivel avatar sivel commented on June 1, 2024 1

I don't believe anything needs to be done about this. I can see ways that this task could be improved, but since it is allowing either a dict/hash/map or just a string, it is probably best written like this instead of complicated filter logic.

The warning is basically stating that squashing the loop into a single invocation of the pip module will no longer happen in 2.11. This task will continue working, it may just be slower in the future, as it will invoke pip for each item in the loop.

The comment above clarifies some additional things that I was going to add here as well.

from ansible-role-pip.

geerlingguy avatar geerlingguy commented on June 1, 2024 1

@sivel thanks for clarifying. I think I'll leave this issue open until 2.11 anyways, just so people bumping into it have a reference point.

from ansible-role-pip.

geerlingguy avatar geerlingguy commented on June 1, 2024

Still don't know what to do for this.

from ansible-role-pip.

geerlingguy avatar geerlingguy commented on June 1, 2024

According to some internal chatter, it sounds like the task will still work in 2.11, it just won't 'squash' all the loop items into one execution of the task. So instead of installing like:

pip install package1===1.2.3 package2===2.3.4

It would install like:

pip install package1===1.2.3
pip install package2===2.3.4

If that's the case, this doesn't seem like a big deal to me; the convenience of easy control over all the pip package install parameters (per package) is more important than task execution time (considering most of my playbooks maybe install 2-3 packages total, not hundreds).

from ansible-role-pip.

stale avatar stale commented on June 1, 2024

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

from ansible-role-pip.

stale avatar stale commented on June 1, 2024

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.

from ansible-role-pip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.