[BUG] environment-lines are overwritten in /etc/systemd/system/kubelet.service.d/10-kubeadm.conf about ansible-role-kubernetes HOT 6 CLOSED

Line https://github.com/geerlingguy/ansible-role-kubernetes/blob/master/tasks/kubelet-setup.yml#L18 should be more explizitely, something like

kubelet_args_regexp: '^Environment=KUBELET_EXTRA_ARGS'

Actually I have deleted my damaged node and have little time, so I cannot create a PR nor run a test.

from ansible-role-kubernetes.

The problem is also, that the file /etc/default/kubelet is not longer installed by the ubuntu-package, so https://github.com/geerlingguy/ansible-role-kubernetes/blob/master/tasks/kubelet-setup.yml#L2-L5 does not work anymore.
kubernetes/release#654

from ansible-role-kubernetes.

If somebody has a PR I can run a test against some hosts.

from ansible-role-kubernetes.

+1 to this bug. This is also affecting me too. In my case the kubeadm init fails because we are missing Environment="KUBELET_CONFIG_ARGS=--config=/var/lib/kubelet/config.yaml" in the systemd file. I am running ubuntu 16.04 and trying to install kubernetes stable-1.13. What I did for now was turned the kubet-setup.yml tasks into a template that installs the kubelet service file in /etc/systemd and added a new handler to restart the systemd/kublet if it changes. If i can get some time I try to fix this in a better way and make a PR, but perhaps a template for the systemd kubelet service might be the best option after all?

from ansible-role-kubernetes.

I would not overwrite the systemd-unit if it is not really necessary. Instead, I would prefer the solution to create and use /etc/default/kubelet with this role - at least on Debian/Ubuntu-based systems.

As it is given in kubernetes/release#654 (comment) , the motivation for not installing the file with the debian-package anymore is: This file exists for users to customize.

So this is what the ansible-role does here: customizing.

Also, this should prevent any problems caused by changing the systemd-units by the maintainers - as we just had with docker in docker/for-linux#476

from ansible-role-kubernetes.

I believe this was partially fixed in #46 / #42. However I also have open #4 which is meant to use the newer config layout (this role was originally written in the 1.10 era).

Please follow / share on that issue for further improvements / changes from the env-var-based settings.

from ansible-role-kubernetes.