Code Monkey home page Code Monkey logo

Comments (3)

xesco avatar xesco commented on June 15, 2024 1

Got it! Then it make sense to keep it the way it is.
It's kind of neat to have to option two switch from one to another, so I will keep it that way.

Feel free to close the issue :)

Thanks.

from ansible-role-ansible.

geerlingguy avatar geerlingguy commented on June 15, 2024

I was going to say this could be as simple as putting all the OS install includes in a block with a condition on the ansible_install_method.

However, there's one feature of this role (

ansible-role-ansible/tasks/main.yml

Line 4 in 00ff01e

ansible_package_state: "{{ 'present' if ansible_install_method == 'package' else 'absent' }}"
) that relies on the package management to be working—that is, you can switch between a pip install and a system package install via the linked code above, and that would not work (if you had a package install and were switching to pip, for instance) if we made it so the package install tasks didn't run...

Kind of torn as to whether I should drop that feature or not, I would have to if I made the package install part conditional.

from ansible-role-ansible.

geerlingguy avatar geerlingguy commented on June 15, 2024

Sounds good, thanks for posting the issue, it's definitely something where there are a few benefits either way.

from ansible-role-ansible.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.