Comments (7)
Change it in light.js
from nativebase.
doesn't that defeat the purpose of including a library if you have to manually edit it to change something that seems like it would be changeable via props?
from nativebase.
The point of using variables is that, you can define it in one place and it remains consistent throughout your application. But since some people aren't big fans of the DRY approach, we'll add it with textStyle
in our next release.
from nativebase.
I guess my point is mainly that if you're working on a project with someone
or a team of devs and using this library you'd have to create your own fork
to manage those variables because the base import from npm installing your
package won't have your custom variables. Perhaps forcing a vars file or
something a the root of the application that defines everything is
approachable? DRY is ideal.. that being said it's a pain in the ass to have
to manage your own fork for every library you want to include in your
application too.
On Mon, Jul 18, 2016 at 11:28 PM Sankhadeep Roy [email protected]
wrote:
The point of using variables is that, you can define it in one place and
it remains consistent throughout your application. But since some people
aren't big fans of the DRY approach, we'll add it with textStyle in our
next release.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#46 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAg4DA8IfldyaPRIprBybjVIrlQa79gvks5qXGCVgaJpZM4I37et
.Zachary Zimbler
814-441-2968
http://zzimbler.com
from nativebase.
I understand your problem. It indeed can get difficult to manage. That is why there is another option of having your own variable.js file, and import from there.
import theme from '../{variable.js path}';
<Container theme={theme}>
// your content
</Container>
from nativebase.
ah, that should work. thanks
On Mon, Jul 18, 2016 at 11:36 PM Sankhadeep Roy [email protected]
wrote:
I understand your problem. It indeed can get difficult to manage. That is
why there is another option of having your own variable.js file, and import
from there.import theme from '../{variable.js path}';
// your content
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#46 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAg4DJfbYNTP61zJrYV05VwRfiJi82Ltks5qXGJcgaJpZM4I37et
.Zachary Zimbler
814-441-2968
http://zzimbler.com
from nativebase.
Cool, just copy over all the contents of light.js to your file and set your own default values.
from nativebase.
Related Issues (20)
- SSRProvider it`s not necessary in React18 HOT 1
- <Item> tag not working
- How to get theme in React Class Components ?
- Why does toast.isActive() only take effect when placement is set to bottom
- Error in React 18
- Select with InputLeftElement
- In React 18, SSRProvider is not necessary and is a noop. HOT 1
- Base style extendTheme for Button component does not work
- onPress triggers twice, when activated via Enter key
- Disabled Button is not WCAG accessible and there is no way to set alternative color with themes other than using opacity.
- when use the useToast, state value is initialized
- Codesandbox demo broken
- Demo doesn't work in Expo snack
- Menu placement is wrong
- native-base contains invalid configuration: "dependency.assets" is not allowed HOT 1
- `multiline` and `value` on the same TextArea causes input letters to be continuously added and deleted HOT 2
- Text capitalize ios issue
- Cause flicker with Next 14 HOT 1
- Radio.Group should allow un-selecting a radio button by changing `value` prop
- Input control should show red border if user type wrong string in React Native Windows
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nativebase.