Comments (1)
Commit 27b0f12 introduces a test that kind of resolves this issue.
The test works by running the steady state solver for 80 steps, saving snapshot 1 at step 40 and snapshot 2 at step 80. It then restarts from snapshot 1 and saves snapshot 3, also at 80 steps. A lua custom post script then compares the L2 normal of the pressure differences between snapshot 3 and 2, which should be in the range of machine zero if the solution was written and read correctly.
Some limitations:
- This only exercises the NK solver, which has its own codepath for reading and writing solution files.
- We only test the gziptext legacy format, though others could be added easily
- We have to fix the CFL.
This last thing is a problem, because it means the new test wouldn't have caught the original bug that prompted this issue, where the CFL was read in incorrectly during a restart. Unfortunately, allowing the CFL to vary automatically with the residual introduces a hysteresis in the solver, which means the two snapshots don't match to within machine precision, even though they aren't noticeably different.
I'm not exactly sure what to do about this. It might be an academic problem that isn't worth fixing, even though it would be nice if we did.
from gdtk.
Related Issues (20)
- Turbulence model method gmres_scaling_factor likely obselete HOT 1
- Parallelism HOT 10
- compilation problems HOT 5
- Extract Surfaces Via Group Label HOT 2
- Segmentation fault when setting config.shock_detector_smoothing HOT 8
- High memory usage during prep of large grids HOT 2
- Import mesh from auto meshing program HOT 2
- L1D piston brake completely prevents recoil HOT 4
- Feature request: Access reaction rates in postprocessing HOT 1
- read_from_text function no longer works with structured vtk files HOT 1
- 3D Grid Import HOT 3
- Prepartitioned grid import for massively parallel job - very slow time integration HOT 2
- Binary diffusion coefficient routine missing from python gas interface HOT 1
- Gridding and Spline Issue HOT 1
- RMS quantities on Eilmer HOT 6
- Error running across multiple nodes HOT 5
- Config option diffuse_wall_bcs_on_init can cause problems with turbulent simulations HOT 1
- GridPro structured grid fails to produce meaningful flow? HOT 2
- Stagnation inflow boundary condition incompatible with two temp models HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gdtk.