Code Monkey home page Code Monkey logo

Comments (2)

amanem1 avatar amanem1 commented on June 19, 2024

hi i have sent a pr , can you check and tell, what to improve.!

from photo_effect.

srishti-negi avatar srishti-negi commented on June 19, 2024

hi i have sent a pr , can you check and tell, what to improve.!

Hey!
There are a couple of issues with this pr. I have listed them below, please make the necessary changes.

  1. The function for image blurring is 'GaussianBlur' not 'gaussianBlur'.
  2. As stated in the issue, the purpose of this function was to render the effect on the frame, so instead of edges you need to modify the frame variable.
  3. There is no need to use imshow function as the purpose of the edge_detection function is to return image as a bytes object without displaying it. There is another function(out of scope of this issue) which is responsible for displaying this image.

from photo_effect.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.