Support for .include directive about docker-systemctl-replacement HOT 7 CLOSED

What's missing here is a testcase however.

from docker-systemctl-replacement.

I have tried to find a definition of the include-syntax but the sytemd documentation is silent about that.

https://www.freedesktop.org/software/systemd/man/systemd.syntax.html

from docker-systemctl-replacement.

The only indications I've found that .include syntax is official are:

1. systemd-analyze verify <service-name> does not report any issues when you use .include, but fails if you don't use .include. Take the following example:

/etc/systemd/system/postgresql-9.6.service:

.include /var/lib/systemd/system/postgresql-9.6.service

/var/lib/systemd/system/postgresql-9.6.service:

ExecStart=<command_to_start_database>
...

Given those two files, if you don't include the one from /var/lib/systemd/system, the verify command will fail because the file that defines the ExecStart (and whatever other directives a service requires to be verified) is not read. However, if you use .include, it works because the .include directive reads the file.

2. This article: https://www.certdepot.net/rhel-7-systemd-unit-file-customization/

I ran across this issue when trying to use the postgresql Puppet module from Puppetlabs. In their template for /etc/systemd/system/postgresql-<version>.service, they use the '.include' directive. It seems to be a "hidden" feature?

UPDATE: after quick grep through the systemd source code, it appears that .include is implemented, but considered deprecated and to be removed in a future version of systemd. See https://github.com/systemd/systemd/blob/master/man/systemd.unit.xml, line 184 for details. I will submit a ticket to the Puppet module project I referenced earlier for them to update their unit file to be a drop-in .conf file instead. For now, could we keep this feature so that my current version of the module works? :)

from docker-systemctl-replacement.

Yes, we will keep this feature. A recursive call is actually a simple solution that is "safe and sound".

I will open a bug ticket on systemd to notify them. They should actually mention the old feature in their documentation somewhere as officially "deprecated". I guess they did simply forget about it - as "systemd-analyze" does not mark any problems about it.

from docker-systemctl-replacement.

Systemd is about to mark it officially as "deprecated".

keszybz/systemd@37d5c10

However systemd will continue to support the syntax - with a warning.
Possibly systemctl.py should also print a warning message when coming across that feature.

from docker-systemctl-replacement.

I have done so, adding an error-message but not breaking the parsing step itself.

As this feature is deprecated I do not care for a testcase. That allows to close the issue.

Thanks for your help, I do really appreciate that.

from docker-systemctl-replacement.

You're very welcome--thanks for authoring this awesome tool!

from docker-systemctl-replacement.