Mouse hover steals focus about gowid HOT 7 CLOSED

It seems to only happen with a columns widget. Pile widgets don't have this behavior. In a way, mouse hovering causing focus events is a nice feature, just inconsistent with the library. A separate mouse focus widget might be kind of cool.

I came up with a fix for the columns widget, but I don't know if it's the right way to approach it. What do you think of this?

On widgets/columns/columns.go line 300:
Original

if evm, ok := ev.(*tcell.EventMouse); ok {

My proposal

if evm, ok := ev.(*tcell.EventMouse); ok && evm.Buttons() != 0 {

from gowid.

Hang on, that proposed fix causes other issues with mouse clicks in columns. I'll see if I can work out a better solution.

from gowid.

Thanks :) I'll take a look at your examples this weekend

from gowid.

Hi @r-smith - could you try your example again with gowid updated to commit 30a0793? Let me know!

from gowid.

Err, I changed my mind 😕 Could you try the branch mousefocus instead? I'm not 100% sure of these changes yet, though so far they seem well-behaved. I put them on a branch for a couple of days out of caution. You can make your app use this branch with something like this, assuming your example above is called myapp.go:

mkdir myapp
mv myapp.go myapp/
cd myapp
go mod init myapp
export GO111MODULE=on
go get github.com/gcla/gowid@mousefocus
go run myapp.go

I think this also addresses issue #16.

from gowid.

I tried the mousefocus branch and it seems to work well. It fixes both issues I reported and so far I can't find any unwanted side effects. I think it looks good. Thanks for taking the time to look into this.

from gowid.

np, thanks for the bug report :) I'll close this now

from gowid.