Code Monkey home page Code Monkey logo

Comments (7)

gboehl avatar gboehl commented on July 24, 2024

Hi, sorry that I am just seeing this now. Would you want to send a pull request with your fix? That would be great!

from pynare.

NarekOhanyan avatar NarekOhanyan commented on July 24, 2024

Hi, sure, I would be happy to make PR. However, this fix would work for a Linux-based OS, whereas dynare would be installed in different paths on Mac and Windows. Hence a complete solution would require a more general approach.

from pynare.

gboehl avatar gboehl commented on July 24, 2024

From my perspective this should be fine. I would assume that this is primarily interesting for linux users after all. In any case, you could wrap your fix in a

if platform == "linux" or platform == "linux2":
    # your fix

from pynare.

gboehl avatar gboehl commented on July 24, 2024

But wouldn't the better solution be to permanently add dynare to your matlab path? Also, the path of dynare is not the same across linux distributions (at least not for Arch vs. Ubuntu).

In that case I would just suggest to document this need to set the path beforehand.

from pynare.

NarekOhanyan avatar NarekOhanyan commented on July 24, 2024

You're right, the installation path may be different even across different linux distributions, so probably adding something about it in the documentation is a good idea. But I think instead of asking users to add dynare path to Matlab permanently (which may not be straightforward for them to do), we may ask users to provide the dynare path when they import the library. It can look something like this:

from pynare import pynare, set_dynare_path
set_dynare_path('/usr/lib/dynare/matlab/')
mod = pynare('modfile.mod')

from pynare.

gboehl avatar gboehl commented on July 24, 2024

from pynare.

NarekOhanyan avatar NarekOhanyan commented on July 24, 2024

Sure, I will take care of it!

from pynare.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.