Code Monkey home page Code Monkey logo

Comments (3)

AntonioND avatar AntonioND commented on May 14, 2024

I'm taking a look at this, but I'll post my findings so far:

For numbers, the problem is that the lexer, as soon as it finds a number, it looks for the first non-valid character for a number, sends it to the parser and continues. That way, when you do 1\1 the parser sees 1 \1. However, when it's done the other way around, the lexer finds the first numeric value when the argument is replaced by the value of the argument. Only after finishing the argument it finds the other number, so it considers it a continuation.

For labels and EQUs, it works just fine, at least with the current version.

Also, it seems that EQUSes can't be used in the list of macro arguments, the lexer used for macro arguments is a lot simpler than the one used for any other part of the code and interprets them as simple strings of characters that are copied when used from inside the macro. Macro arguments only allow a few escape characters (including macro arguments) as seen in yylex_MACROARGS. This has to be documented.

EDIT: Explanation of that last part:

LIST EQUS "3, 4"

MyMacro : MACRO
    DB \1
ENDM

    MyMacro 1, 2 ; interpreted as two arguments
    MyMacro "1\, 2" ; interpreted as a string (the comma has to be escaped)
    MyMacro LIST ; \1 = LIST, it is expanded when parsing the insides of the macro

from rgbds.

ISSOtm avatar ISSOtm commented on May 14, 2024

State of this right now: the first block complains that A_A_A and A_B_C are not defined, respectively, so that's good.

The second block returns 11 (expected), -1 (expected), -1 (expected), a syntax error (oops), and another syntax error (oops)

from rgbds.

ISSOtm avatar ISSOtm commented on May 14, 2024

Fixed by #557.

from rgbds.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.