Comments (5)
Can you try to just add .Where(x => x.Version > fromVersion)
to the bottom of your method?
from cqrslite.
OK, so IEventStore.Get, in the sample, only loads those events that haven't already been loaded?
My implementation of IEventStore.Get just now reads all events related to the stream for that aggregate:
public async Task<IEnumerable<IEvent>> Get(Guid aggregateId, int fromVersion)
{
var streamEvents = new List<ResolvedEvent>();
StreamEventsSlice currentSlice;
var nextSliceStart = (long)StreamPosition.Start;
do
{
currentSlice = await _connection.ReadStreamEventsForwardAsync(
StreamName($"booking-{aggregateId}"), nextSliceStart, 200, false);
nextSliceStart = currentSlice.NextEventNumber;
streamEvents.AddRange(currentSlice.Events);
} while (!currentSlice.IsEndOfStream);
return streamEvents.Select(e => (BaseEvent)RebuildEvent(e));
}
This is pretty much just a lift and drop from the Event Store documentation (http://docs.geteventstore.com/dotnet-api/4.0.0/reading-events/).
The input for fromVersion will be 0 given that that's the expected version.
from cqrslite.
Yes I can! That fixes it.
Ok, understanding adjusted I think. IEventStore.Get MUST only return those events that have a version greater than that passed in. I was going on the assumption that I could ignore the fromVersion for the time being assuming it was just a convenience provided to improve performance, but it's actually linked to the successful saving of the new events.
Thanks for your help and the prompt replies!
from cqrslite.
What does _eventStore.Get
return in the method you are asking for and what is the input? The implementation in the sample is like this events?.Where(x => x.Version > fromVersion) ?? new List<IEvent>()
, so it only returns the events saved after the current version.
from cqrslite.
Yes, that's the way it is now. It could possibly be moved into the repository as well, but where put there for performance reasons, so the eventstore would not necessarily need to load all events every time.
from cqrslite.
Related Issues (20)
- Concurrency errors HOT 7
- Error EventIdIncorrectException in the new version HOT 2
- Snapshot aggregte returns an aggregate with default values. HOT 8
- Another article about CQRSlite HOT 1
- Where are the query and event handlers being registered? HOT 1
- Not sure if this is a bug or intentional... HOT 3
- Question about events and new commands HOT 4
- How to "rollback" to a specific version? HOT 2
- Are async handlers waited? HOT 1
- Untyped Save<T> when calling from Session HOT 2
- Project maintained?
- How to handle the version property in react or angular frontend? HOT 3
- Aggregate may change identity during history load HOT 5
- You can no longer return IServiceProvider from ConfigureServices as in Web example from .NET Core 3 HOT 9
- Implement snapshot HOT 4
- DSL for CQRSlite HOT 3
- Service fabric doesn't support GenericHostBuilder HOT 5
- Commands, events and being idempotent? HOT 2
- Entity Framework Problem HOT 6
- Add netstandard2.1 and correct dependencies to match the standards HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cqrslite.