MinAuthorities is not checked on auto removal about substrate-validator-set HOT 4 CLOSED

That's because remove_offline_validators is called in the session change hook and removes the validators who reported offline during the session that is ending. Even if we put the check of MinAuthorities here, the offline validators that are not removed (because of this check) will not produce blocks and will have the same overall effect on the runtime.

The MinAuthorities check is to not go below the threshold when manually removing healthy validators. Makes sense?

from substrate-validator-set.

Yes, it makes sense. Thank you

from substrate-validator-set.

Same problem when initializing genesis

Error:

Thread 'main' panicked at 'At least 2 validators should be initialized', /home/dev/.cargo/git/checkouts/substrate-validator-set-f1aaacaa79a24970/91375ae/src/lib.rs:172

Code:

assert!(validators.len() > 1, "At least 2 validators should be initialized");

https://github.com/gautamdhameja/substrate-validator-set/blob/master/src/lib.rs#L172

from substrate-validator-set.

My MR to the fix problem:

#34

from substrate-validator-set.