Comments (4)
@polarathene can you say more about this? It should trigger when your first PR is merged, regardless of other PRs being open.
If that didnβt happen, can you please send links to your PRs so we can dig into this a bit? Thanks!
from peril-gatsbyjs.
Here are my PRs(filtered by closed which they all are presently).
My first PR submitted to Gatsby is this one,
and this is my first merged PR.
I would have expected the bot to congratulate me on the first PR that was actually merged, not wait until my first submitted PR was merged(which I imagine for some when rejected, they'd never hear from the bot?).
Swag store worked fine though, it had recognized the merged PR prior to the bot congratulating my first submitted PR on being merged.
So just to clarify:
- Swag store logic works fine once a PR is merged.
- The bot congratulates once the first submitted PR is merged, not on the first merged PR.
from peril-gatsbyjs.
@gatsbyjs/core @gatsbyjs/ecosystem something is weird here, and I'm not quite sure how this is possible, but apparently Peril is following the first PR, not the first merged PR. π
from peril-gatsbyjs.
Hiya!
This issue has gone quiet. Spooky quiet. π»
We get a lot of issues, so we currently close issues after 30 days of inactivity. Itβs been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contributefor more information about opening PRs, triaging issues, and contributing!
Thanks for being a part of the Gatsby community! πͺπ
from peril-gatsbyjs.
Related Issues (20)
- How about now? HOT 2
- Will it work now that everything is enabled?
- How is the latest Peril version doing? HOT 1
- What happens when DB-based rules are triggered? HOT 1
- [perilbot] Verify that starters and sites don't go in the wrong .yml file HOT 5
- [perilbot] Enforce Conventional Commits format in PR titles HOT 1
- [perilbot] Add link to accept invitation to the welcome comment HOT 4
- Add all image formats supported by Sharp to image validation HOT 2
- GitHub image hosting - please ignore
- Review and edit the stalebot messages to be more inline with the Gatsby "voice" HOT 3
- Require code review by a codeowner only for changes over a certain size HOT 2
- Commenting on a stale issue doesnβt always mark it as unstale
- Exclude bots from being added automatically to contributors
- Duplicated labels? HOT 3
- Investigate why the `not stale` rule isn't working HOT 5
- Feature: don't close issues if they have a related PR open? HOT 3
- Fix gatsbot re-commenting on already closed issues HOT 2
- Link to "how to contribute" page and add a nudge to submit PRs to fix stale issues HOT 4
- Feature: Add ability to notify users when Gatsby team is away HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from peril-gatsbyjs.