Code Monkey home page Code Monkey logo

Comments (4)

jlengstorf avatar jlengstorf commented on June 28, 2024

@polarathene can you say more about this? It should trigger when your first PR is merged, regardless of other PRs being open.

If that didn’t happen, can you please send links to your PRs so we can dig into this a bit? Thanks!

from peril-gatsbyjs.

polarathene avatar polarathene commented on June 28, 2024

Here are my PRs(filtered by closed which they all are presently).

My first PR submitted to Gatsby is this one,
and this is my first merged PR.

I would have expected the bot to congratulate me on the first PR that was actually merged, not wait until my first submitted PR was merged(which I imagine for some when rejected, they'd never hear from the bot?).

Swag store worked fine though, it had recognized the merged PR prior to the bot congratulating my first submitted PR on being merged.


So just to clarify:

  • Swag store logic works fine once a PR is merged.
  • The bot congratulates once the first submitted PR is merged, not on the first merged PR.

from peril-gatsbyjs.

jlengstorf avatar jlengstorf commented on June 28, 2024

@gatsbyjs/core @gatsbyjs/ecosystem something is weird here, and I'm not quite sure how this is possible, but apparently Peril is following the first PR, not the first merged PR. πŸ˜•

from peril-gatsbyjs.

gatsbot avatar gatsbot commented on June 28, 2024

Hiya!

This issue has gone quiet. Spooky quiet. πŸ‘»

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contributefor more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! πŸ’ͺπŸ’œ

from peril-gatsbyjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.