Comments (18)
Yeah definitely, otherwise we could also create something like a @gatsby-uc
scope to put it under 🙂
I'll look into moving the repo asap and let you know when I have questions (will probably have some around CI etc.)
from plugins.
Hey folks 👋
Thanks for the ping. @moonmeister DM'd me which was a great bat signal to reply and check in on this. Thank you!
Here's what I've done:
- Added @moonmeister as an owner of the gatsby-source-s3 package
Here's what I will do:
- Say thank you to both ;)
Thank you!! I really appreciate you all taking the lead on this and improving the lives of Gatsby users using S3. One thing that would be really cool is a demo working on Gatsby Cloud, but totally up to you!
from plugins.
@moonmeister you can feel free to do whatever you'd like to the README, mention it's (my initial version of gatsby-source-s3) deprecated in favor of this package, etc. etc. You have carte blanche, and I trust your judgment!
from plugins.
Hey @robinmetral , I'll be talking at Gatsby Conf in March regarding the GUC and some of the cool plugins we are maintaining. I'd love for gatsby-source-s3
to be apart of that. Let me know if you have any questions. The two actions I need from you (moving the repo and giving me npm permissions) shouldn't take more than 5 minutes. Some time this week or next would be prefered. Thanks!
from plugins.
Hey @moonmeister, happy 2022! I'm super sorry, the past few months were crazy. I'm stoked to hear about the Gatsby Conf plans and I promise I'll get this done by EOW (at least the ownership transfer). After that I'll try to help with the e2e test setup etc., which probably won't be as straightforward to move over, but let's see 🙂
from plugins.
Oops, I need to have the permission to create repos in gatsby-uc
to be able to complete the transfer.
I've invited you as a maintainer on the npm package 🙂 (although you probably don't need it since we'll likely be using gatsby-source-s3
moving forward)
from plugins.
I've invited you to be a maintainer
from plugins.
I'm guessing by gatsby-source-pinterest
you mean s3?
from plugins.
Yes sorry 🙈 long week and many mixing plugins, I'm starting to mix them up 😄 (edited)
from plugins.
DONE!
from plugins.
Hello Robin! We'd love to host the plugin. Bellow are the steps for you and me. Since this is published under your user scope I'm not sure if that makes permissions different or if they're the same. It would be nice if @DSchau could give us access to the gatsby-source-s3
name and we could just depreciate @robinmetral/gatsby-source-s3
in favor of that.
Dustin, you interested?
Robin, Let me know if you have any questions.
Tasks
Contributor Tasks:
- Move Repo to
gatsby-uc
- Add
moonmeister
as a maintainer on your npm package.
Admin Tasks:
- Move Code into
gatsby-uc/plugins
repo- Update Readme in old repo to redirect folks to new location
- Archive old Repo
- Close any irrelevant PRs/Issues
- Move/Comment on still applicable issues
- Update Plugin with best practices
- Fix tests
- Publish new version
from plugins.
Dustin got me added to gatsby-source-s3
from plugins.
@robinmetral Would love to get this moved if you got time to move that repo into the gatsby-uc
.
from plugins.
You should be able to request the transfer and I just accept it. 🤔
from plugins.
Awesome! Repo moved at gatsby-uc/gatsby-source-s3 ✅
Let me know if you need help for next steps. Some thoughts:
- move the project into
gatsby-uc/plugins
- we'll need to figure out what to do with e2e tests here since they connect to my personal AWS account for now
- happy to help with other things if I can, but generally the repo is pretty up-to-date already (latest
gatsby
version etc.). Feel free to get in touch with any questions!
- publish a new version of
gatsby-source-s3
based on@robinmetral/gatsby-source-s3
- deprecate
@robinmetral/gatsby-source-s3
- happy to handle this part once the new
gatsby-source-s3
has been published, telling people to switch over
- happy to handle this part once the new
from plugins.
Okay @robinmetral for tests, do you mind if we just continue using your existing s3 buckets? if so can you DM me the needed secrets? thanks!
from plugins.
I think this would be fine for now, yes 🙂 let me grab new secrets with the proper access and I'll send them over DM later today
from plugins.
Awesome! Thanks a lot for this 🙌 Can't wait to see the Gatsby UC grow!
from plugins.
Related Issues (20)
- bug(gatsby-source-strapi): Request failed with status code 500 HOT 4
- bug(gatsby-source-strapi): fetching content twice (via relationships) fails to transform to Markdown HOT 2
- feat(gatsby-source-strapi): Transform markdown images in-place HOT 1
- bug(gatsby-source-strapi): queryLimit breaks incremental build HOT 4
- bug(gatsby-strapi-source): With external and Strapi images in Markdown, some Strapi images are missing/blended HOT 1
- bug(gatsby-source-strapi): The plugin "gatsby-source-strapi" created a node of a type "File" owned by "gatsby-source-filesystem". HOT 36
- bug(<gatsby-source-strapi>): <"gatsby-source-strapi" threw an error while running the sourceNodes lifecycle> HOT 1
- bug(gatsby-source-strapi): updating a JSON fields gets lost HOT 1
- feat(gatsby-source-strapi): Generated Types HOT 7
- bug(gatsby-plugin-fastify): `assetPrefix` Not Working HOT 3
- feat(gatsby-source-strapi): timeout setting for queries HOT 2
- bug(gatsby source strapi): Components within Dynamic Zones are not "getting through" HOT 4
- bug(gatsby-source-airtable): Duplicate Dot in File Extension HOT 4
- bug(gatsby-plugin-fastify): Error fetching page data for /using-ssr when pagePrefix is set HOT 5
- bug(gatsby-plugin-fastify): Doesn't work as expected for SSR pages HOT 6
- bug(gatsby-plugin-fastify): Server function throws 'stream.on is not a function' after being called. HOT 4
- bug(gatsby-plugin-fastify): SSR pages don't work at all on Gatsby-Wordpress site HOT 1
- feat(gatsby-source-strapi): support for Strapi 5
- bug(gatsby-source-strapi): GraphQL fragment queries only work if all possible components of a dynamic zone are actually used in the current content HOT 1
- bug(gatsby-source-strapi): can't get strapi component data HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from plugins.