Comments (2)
This is less of a problem of Upstart, and more one of Docker itself.
Because open ports can only be specified with docker run
, and cannot be changed afterwards (one could argue that this is "by design" for Docker), changing the configuration of a container requires removing the container, and start a new container.
Just docker restart
ing a container does not suffice.
The problem with this is that the container might contain data the user wants to keep, but which would be lost when doing docker rm
on the container. Some container can safely be deleted and rerun (consider a Skydock container that contains an immutable configuraiton), other containers should only be removed if the user explicitly requests to do so.
Proposed fix: Add a parameter to docker::run
which allows the user to specify whether containers should be temporary (i.e. removed on initctl stop
) or permanent. Would it be possible to use --rm
parameter of docker run
. Additionally, one could define an additional action for the init scripts to explicitly remove and rerun the container (Is this possible for Upstart?).
Update: According to the the Upstart Documentation calling initctl restart <jobname>
does not reload a jobs config from disk.
from garethr-docker.
We've now changed over to sysv from docker run which should avoid this issue and a few other init related problems.
from garethr-docker.
Related Issues (20)
- docker::run ensure=> 'absent' inconsistent HOT 1
- env attribute does not work when a "-" is present HOT 4
- Using registry mirror
- CentOS/7 : Having "INSECURE_REGISTRY" option HOT 1
- Use docker::swarm as an exported resource HOT 5
- Error while evaluating a Resource Statement, Apt::Source[docker] HOT 3
- docker image, docker_tar and restart containers only on update? HOT 4
- Allow Docker to configure direct-lvm mode
- Docker 17.06 cannot get HOT 7
- Connecting to Docker Hub HOT 1
- RHEL 7 extra repository error
- Support docker-ce
- Please mark this module as deprecated and redirect to puppetlabs/puppetlabs-docker HOT 1
- Amazon Linux 2 support HOT 2
- Ubuntu: Install docker-ce instead of docker-engine? HOT 1
- Notice of Newer PuppetLabs Module HOT 1
- Docker registry auth doesn't check if it authed already? HOT 1
- $docker::service_provider is not respected by docker::run HOT 1
- support for Centos 8 HOT 1
- Please point users of this module to https://github.com/puppetlabs/puppetlabs-docker
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from garethr-docker.