Comments (3)
Quoted from #54 (comment) and #54 (comment)
@unmarshall raised a valid point about setting object selectors in webhooks:
Use the object selector only if the webhook is opt-in, because end users may skip the admission webhook by setting the labels.
For the gardener use case, we are the end-users of Kupid as well. So we control what labels we set on the pod-groups (statefulsets, deployments, etc) that Kupid is to mutate.
This can be achieved using the helm charts. We can read the {{ .Values.policies.*.podLabels }}
section from each policy and pass that as a set to Kupid as a command-line argument. Kupid can simply set these on the webhooks that it creates.
Now, external users of Kupid can choose to leave this empty, in which case Kupid will not add any object selector to the webhooks, which means all resources will be considered (no change in behavior).
from kupid.
/assign
from kupid.
/unassign
from kupid.
Related Issues (12)
- Pending tasks for gardener integration HOT 3
- Support full strategic merge patch
- Missing priorityClass for kupid-extension
- Kupid should not generate the MutatingWebhookConfiguration with the rule to mutate Jobs for updates
- Support for k8s 1.22+
- Drop Kupid in favor of an alternative (OPA Gatekeeper or Kyverno...) HOT 10
- Handling failures in applying the Scheduling policies. HOT 1
- Log the first mutation done to affinity rules by kupid
- Allow configuring QPS and burst via helm chart HOT 2
- Add healthz endpoint and metrics
- Improve error logging HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kupid.