Code Monkey home page Code Monkey logo

Comments (8)

eysi09 avatar eysi09 commented on August 18, 2024 1

Would be nice to be able to git clone the examples separately though.

from garden.

edvald avatar edvald commented on August 18, 2024

Actually, we may want to keep them in the same repo if we go for #171 ?

from garden.

eysi09 avatar eysi09 commented on August 18, 2024

There's actually already an examples repo: https://github.com/garden-io/garden-examples

Wasn't the plan to maintain those examples separately and have other examples within the project that would function more as integration test?

from garden.

edvald avatar edvald commented on August 18, 2024

Yeah, I just kept the issue open (also because of the question above, which was just a thought) because we still have the examples in this repo. We should at least move them to the test/integ directory then to be sure not to cause confusion, and maybe just fold the features we want to integration test into a single project.

One issue with having the examples in a separate repo, is that we don't run any tests there, and don't pin the examples to a particular version of garden-cli. I've already seen cases where the examples have broken, and if we want to keep them separate we need to add some setup to automatically test them. Otherwise they'll inevitably drift, especially as our APIs are still changing fairly often.

from garden.

vkorbes avatar vkorbes commented on August 18, 2024

I propose we should keep the examples in the main repo, and then have them mirrored to a separate examples repo.

This way it's easier for us to commit changes to the code functionality and the respective adjustments to the examples in one single PR, for example, but we still have a separate and much lighter/smaller repo of examples only that we can use for didactic reasons.

Thoughts?

from garden.

thsig avatar thsig commented on August 18, 2024

Ellen and I talked about this earlier — just to clarify, mirroring = running a script that automatically updates the examples repo with changes to example projects in the main repo.

That way, example projects are still maintained/developed as part of the main dev/test/release workflows.

from garden.

edvald avatar edvald commented on August 18, 2024

Good idea! We could rig that up via Github hooks on master.

from garden.

eysi09 avatar eysi09 commented on August 18, 2024

I'm going to close this one since we have some other thoughts on how to maintain the examples as well, e.g. as submodules in the main project.

from garden.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.