Close audio output when no audio is being generated about datcord HOT 10 CLOSED

Hello,
The latest build from GitHub Actions for the master branch should be built with at least Firefox 102.0 beta. Could you check if it works?

Appimage
Tarball

from datcord.

Just checked it using the link you provided to the Appimage and the symptoms are exactly the same. Phone works when datcord is off. When datcord is launched, the phone continues to play until stopped. Then the phone can never play again until datcord has been quit. I'm not sure if the patch linked above has been properly applied though since the the phone doesn't even regain the ability to play sound over BT with datcord (and speech-distpatcher-dummy) muted in the audio settings. I think the patch was meant to specifically address that.

Looks also like discord just keeps the audio sink running forever (the speaker icon is visible in the datcord icon in the taskbar). Do you have any control over that?

from datcord.

Hello,
I have rebuilt Datcord with the newest changes from Mozilla. I have not done anything special to Datcord that would cause this behavior. Everything that happens when you open discord in Firefox should happen with Datcord. I do not have any control over it besides from applying the aforementioned patch to the source code (it seems that Mozilla has already done that).

Appimage
Tarball

from datcord.

I've just tested this. Same result. Here's some more information:

• In Chrome based browsers, the audio sink initially starts but then goes away without me having to do anything.
• In Firefox 101.0.1 (Arch), the audio sink stays there forever as well as speech-dispatcher-dummy. It doesn't matter if I select "deafen" from discord quick options or if I even mute the tab.
• In Datcord (released version or the Appimage you posted), the results are exactly the same as Firefox 101.0.1. The only thing is I'm not sure if I can mute the tab (tried "deafen"). I press CTRL+M (works in FF) but I have no visual feedback if anything happened. Do you do anything to keyboard shortcuts? If not, this should work and it doesn't.

Hope that helps.

from datcord.

So to add a little extra, I just downloaded both Firefox beta (102.0b8) and nightly (103.0a1) and the symptoms are the same. So I'm not sure if the patch has been merged on their end yet. It has been submitted and accepted but may not be in the main line yet.

So maybe revisit when 102 gets officially released? I don't know.

from datcord.

Just checked on 102.0 (Arch) and the problem persists.

• On chrome-based browser: deafen causes the audio sink to go away after a few seconds.
• On firefox-based browser: nothing causes the audio sink to go away ever.

So, I don't understand what that Firefox patch I linked to was meant to address. I went to Twitch and Youtube using Firefox 102 and muting (but not pausing) there worked exactly as expected - the audio sink disappears. The only difference I could see in the Plasma audio config app was that for Youtube and Twitch the sink was listed as "AudioStream" whereas using discord it shows up as "AudioCallbackDriver."

I guess I don't really understand what's happening or why.

from datcord.

Hello,
It has been a couple of months and I think it is time to revisit this issue and test the newest version of Datcord and/or Firefox.

Appimage
Tarball

from datcord.

Hi,

Just tested your Datcord appimage and the latest Firefox (104.0.2) and the symptoms are exactly the same. Youtube and Twitch (as examples) work as I expect - even pausing allows the phone to produce audio. Discord blocks audio - even when "deafen" is activated. The only way to allow the phone to produce audio is to quit the Discord app (close Datcord or log out/close tab), or change the output device to be something other than the BT device. Chrome browsers work as I'd expect (deafen/mute tab closes the audio stream).

So either I didn't understand what the Firefox patch was fixing, or there's some corner case where the AudioCallbackDriver functions differently to the AudioStream.

from datcord.

Hello,
Does this still happen in Firefox 120? Datcord is now using that.

from datcord.

So I think this may be solved. I'm not 100% sure. I just tested it using both the appimage and the flatpak (and firefox too) and I can get it to work with a little poking. Basically, I can get datcord to make a noise and stop, then I need to press the play/pause button on my headset and then it will finally work. I tried with another headset and it doesn't have that problem.

More detail:
Previously, chrome and firefox based browsers (including datcord) would act differently. Firefox based ones would keep an audio stream running indefinitely whereas chrome ones would turn it off eventually. Firefox ones STILL do this, but the functionality is not the same between the two (audio won't work until I press the play/pause button on the headset). That is, both chrome and firefox fail to play until I press the button. Previously, chrome browsers would start playing without interference after a few seconds. So I think me headset has developed a new problem sometime in the last year or so (firmware update or whatever), that has caused an additional problem, but that has nothing to do with datcord. If no one else reports such an issue, I think this issue can be closed.

from datcord.