Comments (5)
benbrimeyer
commented on August 16, 2024
string.len is not deprecated in lua 5.1
from ga-sdk-roblox.
W-Drew
commented on August 16, 2024
^ @Sleitnick for awareness.
Hm, not commonly used on Roblox at least. Should at the very least use s:len() rather than string.len(s) if there is adversity to the length operator.
from ga-sdk-roblox.
benbrimeyer
commented on August 16, 2024
Not sure what "not commonly used on Roblox" would equate to -- I see it used quite frequently but I dont think that should affect if its used here.
from ga-sdk-roblox.
Sleitnick
commented on August 16, 2024
Interesting, thought it was deprecated. Either way, it definitely seems like standard practice to use # operator over string.len. In fact, I don't think I've ever seen developers on Roblox use string.len. So for the sake of consistency, I would still advocate for the switch proposed here.
from ga-sdk-roblox.
the1schwartz
commented on August 16, 2024
This has been fixed in the latest version.
from ga-sdk-roblox.
Related Issues (20)
- Clarify usage of ProcessReceiptCallback in documentation. HOT 1
- getPlatform returns not successful HOT 7
- Add to wally package manager HOT 15
- SDK broken after Postie update HOT 1
- Update Roblox Model HOT 1
- Issue Showing User Location in GA HOT 1
- No "configureUserId" method
- Errors when installing on Roblox
- SDK fails out of the box on studio test due to wrong protocol HOT 2
- Version 2.2.3 is not in wally HOT 4
- Add Subscription Tracking Support
- Installing from Wally in documentation is incorrect and impossible HOT 1
- addDesignEvent et al. should produce an error if provided a player instead of a user ID
- WARN|GameAnalyticsSDK.Net.Logging.GALogger|Warning/GameAnalytics: Event queue: Failed to send events.
- Naming conflict in latest release (2.2.3)
- Add Roblox Secrets Support for API Key HOT 1
- Latest version has 2 undefined variable errors HOT 1
- Errors from client scripts are no longer sent to GameAnalytics
- "Postie" dependency should be coupled with the "GameAnalytics" module HOT 3
- Use rojo build instead of the current method of creating a rbxmx HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ga-sdk-roblox.