Code Monkey home page Code Monkey logo

Comments (8)

Kampfkarren avatar Kampfkarren commented on August 16, 2024

This was my own script... 🤦‍♂️

from ga-sdk-roblox.

Kampfkarren avatar Kampfkarren commented on August 16, 2024

Wait, no it wasn't.

21:09:37.327 - GameAnalytics is not a valid member of ServerStorage
21:09:37.328 - Stack Begin
21:09:37.328 - Script 'ServerScriptService.GameAnalyticsScript', Line 39

from ga-sdk-roblox.

the1schwartz avatar the1schwartz commented on August 16, 2024

So is the GameAnalytics module not located under ServerStorage in your project?

Maybe there should be added a requirement just like there is one for GameAnalyticsScript (soon to be renamed to GameAnalyticsServer):

if script.Parent.ClassName ~= "ServerStorage" then error("GameAnalytics: Disabled") return end

from ga-sdk-roblox.

Kampfkarren avatar Kampfkarren commented on August 16, 2024

The location shouldn't matter at all IMO.

from ga-sdk-roblox.

the1schwartz avatar the1schwartz commented on August 16, 2024

So how does the GameAnalyticsServer script know where to access the GameAnalytics script from?

from ga-sdk-roblox.

Kampfkarren avatar Kampfkarren commented on August 16, 2024

Good point, your error is a better solution under the assumption #18 makes GameAnalyticsServer a shortcut more than a necessity. The error is kind of vague though, it should mention why it's disabled and how to fix it if it was an error.

from ga-sdk-roblox.

the1schwartz avatar the1schwartz commented on August 16, 2024

Maybe there should be added a requirement just like there is one for GameAnalyticsScript (soon to be renamed to GameAnalyticsServer):

if script.Parent.ClassName ~= "ServerStorage" then error("GameAnalytics: Disabled") return end

This doesn't work for a ModuleScript since it is first called when you require it and then you get the GameAnalytics is not a valid member of ServerStorage error first, but with #19 fixed it is now possible to manually configure and initialize the SDK. Can this be closed now or not?

from ga-sdk-roblox.

Kampfkarren avatar Kampfkarren commented on August 16, 2024

The drop in scripts are fine with that, as long as the module doesn't.

from ga-sdk-roblox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.